content/browser/download/download_item_impl_unittest.cc - Issue 11412202: Made MaybeCompleteDownload private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl_unittest.cc

Issue 11412202: Made MaybeCompleteDownload private. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed virtuals from various private methods on DownloadItemImpl." Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl_unittest.cc

diff --git a/content/browser/download/download_item_impl_unittest.cc b/content/browser/download/download_item_impl_unittest.cc

index f3381685a18064e5356360b762bb7423a3f50c32..21b85c201d3248e3e7a8219fb89f1c34a352d656 100644

--- a/content/browser/download/download_item_impl_unittest.cc

+++ b/content/browser/download/download_item_impl_unittest.cc

@@ -460,13 +460,12 @@ TEST_F(DownloadItemTest, CallbackAfterRename) {

::testing::Mock::VerifyAndClearExpectations(download_file);

::testing::Mock::VerifyAndClearExpectations(mock_delegate());

- item->OnAllDataSaved("");

EXPECT_CALL(*download_file, RenameAndAnnotate(final_path, _))

.WillOnce(ScheduleRenameCallback(final_path));

EXPECT_CALL(*mock_delegate(), ShouldOpenDownload(item, _))

.WillOnce(Return(true));

EXPECT_CALL(*download_file, Detach());

- item->MaybeCompleteDownload();

+ item->DestinationObserverAsWeakPtr()->DestinationCompleted("");

RunAllPendingInMessageLoops();

::testing::Mock::VerifyAndClearExpectations(download_file);

::testing::Mock::VerifyAndClearExpectations(mock_delegate());