Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 11411364: Correctly Mark the new Autofill Popup as Visible when showing just passwords. (Closed)

Created:
8 years ago by csharp
Modified:
8 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, aurimas (slooooooooow)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Correctly Mark the new Autofill Popup as Visible when showing just passwords. BUG=164091 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171085

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M chrome/browser/autofill/autofill_external_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_unittest.cc View 5 chunks +57 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csharp
8 years ago (2012-12-04 19:45:42 UTC) #1
Ilya Sherman
LGTM, thanks :)
8 years ago (2012-12-04 20:01:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/11411364/2001
8 years ago (2012-12-04 20:05:49 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 23:52:38 UTC) #4
Message was sent while issue was closed.
Change committed as 171085

Powered by Google App Engine
This is Rietveld 408576698