Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 11411364: Correctly Mark the new Autofill Popup as Visible when showing just passwords. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/utf_string_conversions.h" 5 #include "base/utf_string_conversions.h"
6 #include "chrome/browser/autofill/autocomplete_history_manager.h" 6 #include "chrome/browser/autofill/autocomplete_history_manager.h"
7 #include "chrome/browser/autofill/autofill_external_delegate.h" 7 #include "chrome/browser/autofill/autofill_external_delegate.h"
8 #include "chrome/browser/autofill/autofill_manager.h" 8 #include "chrome/browser/autofill/autofill_manager.h"
9 #include "chrome/common/autofill_messages.h" 9 #include "chrome/common/autofill_messages.h"
10 #include "chrome/common/chrome_constants.h" 10 #include "chrome/common/chrome_constants.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 if (suggestions.empty()) { 142 if (suggestions.empty()) {
143 HideAutofillPopup(); 143 HideAutofillPopup();
144 return; 144 return;
145 } 145 }
146 146
147 SetBounds(bounds); 147 SetBounds(bounds);
148 148
149 std::vector<string16> empty(suggestions.size()); 149 std::vector<string16> empty(suggestions.size());
150 std::vector<int> password_ids(suggestions.size(), 150 std::vector<int> password_ids(suggestions.size(),
151 WebAutofillClient::MenuItemIDPasswordEntry); 151 WebAutofillClient::MenuItemIDPasswordEntry);
152 popup_visible_ = true;
152 ApplyAutofillSuggestions(suggestions, empty, empty, password_ids); 153 ApplyAutofillSuggestions(suggestions, empty, empty, password_ids);
153 } 154 }
154 155
155 void AutofillExternalDelegate::SetCurrentDataListValues( 156 void AutofillExternalDelegate::SetCurrentDataListValues(
156 const std::vector<string16>& data_list_values, 157 const std::vector<string16>& data_list_values,
157 const std::vector<string16>& data_list_labels, 158 const std::vector<string16>& data_list_labels,
158 const std::vector<string16>& data_list_icons, 159 const std::vector<string16>& data_list_icons,
159 const std::vector<int>& data_list_unique_ids) { 160 const std::vector<int>& data_list_unique_ids) {
160 // TODO(csharp): Modify the code to allow the data list values to change 161 // TODO(csharp): Modify the code to allow the data list values to change
161 // even if the popup is visible. 162 // even if the popup is visible.
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 384
384 385
385 #if defined(OS_MACOSX) 386 #if defined(OS_MACOSX)
386 387
387 void AutofillExternalDelegate::CreateForWebContentsAndManager( 388 void AutofillExternalDelegate::CreateForWebContentsAndManager(
388 content::WebContents* web_contents, 389 content::WebContents* web_contents,
389 AutofillManager* autofill_manager) { 390 AutofillManager* autofill_manager) {
390 } 391 }
391 392
392 #endif 393 #endif
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698