Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: runtime/platform/floating_point_win.cc

Issue 11411188: Fix floating point issues on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Moved round() back to c99_support_win. Cleaned up the code, added comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/platform/floating_point_win.cc
diff --git a/runtime/platform/floating_point_win.cc b/runtime/platform/floating_point_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5a9dd8fe1de8e187a06426f62652ce730dbf8da9
--- /dev/null
+++ b/runtime/platform/floating_point_win.cc
@@ -0,0 +1,37 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include <math.h>
+#include <limits>
+
+#include "platform/globals.h"
+
+// Taken from third_party/v8/src/platform-win32.cc
+double modulo(double x, double y) {
+ // Workaround MS fmod bugs. ECMA-262 says:
Mads Ager (google) 2012/11/28 09:26:26 Please remove reference to ECMA-262.
aam-me 2012/11/28 12:14:36 Done.
+ // dividend is finite and divisor is an infinity => result equals dividend
+ // dividend is a zero and divisor is nonzero finite => result equals dividend
+ if (!(_finite(x) && (!_finite(y) && !isnan(y))) &&
+ !(x == 0 && (y != 0 && _finite(y)))) {
+ x = fmod(x, y);
+ }
+ return x;
+}
+
+// Bring MSVC atan2 behavior in line with standard.
Mads Ager (google) 2012/11/28 09:26:26 I think your changes to this file got lost during
aam-me 2012/11/28 12:14:36 Done.
+double atan2_ieee(double x, double y) {
+ int cls_x = _fpclass(x);
+ int cls_y = _fpclass(y);
+ if (((cls_x & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0) &&
+ ((cls_y & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0)) {
+ bool x_negative = (cls_x & _FPCLASS_NINF) != 0;
+ bool y_negative = (cls_y & _FPCLASS_NINF) != 0;
+ static double atans_at_infinities[2][2] =
+ { { atan2(1., 1.), atan2(1., -1.) },
+ { atan2(-1., 1.), atan2(-1., -1.) } };
+ return atans_at_infinities[x_negative][y_negative];
Mads Ager (google) 2012/11/28 09:26:26 Could you index with ints instead of bools here.
aam-me 2012/11/28 12:14:36 Done.
+ } else {
+ return atan2(x, y);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698