Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: runtime/platform/floating_point_win.cc

Issue 11411188: Fix floating point issues on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Moved round() back to c99_support_win. Cleaned up the code, added comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 #include <math.h>
6 #include <limits>
7
8 #include "platform/globals.h"
9
10 // Taken from third_party/v8/src/platform-win32.cc
11 double modulo(double x, double y) {
12 // Workaround MS fmod bugs. ECMA-262 says:
Mads Ager (google) 2012/11/28 09:26:26 Please remove reference to ECMA-262.
aam-me 2012/11/28 12:14:36 Done.
13 // dividend is finite and divisor is an infinity => result equals dividend
14 // dividend is a zero and divisor is nonzero finite => result equals dividend
15 if (!(_finite(x) && (!_finite(y) && !isnan(y))) &&
16 !(x == 0 && (y != 0 && _finite(y)))) {
17 x = fmod(x, y);
18 }
19 return x;
20 }
21
22 // Bring MSVC atan2 behavior in line with standard.
Mads Ager (google) 2012/11/28 09:26:26 I think your changes to this file got lost during
aam-me 2012/11/28 12:14:36 Done.
23 double atan2_ieee(double x, double y) {
24 int cls_x = _fpclass(x);
25 int cls_y = _fpclass(y);
26 if (((cls_x & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0) &&
27 ((cls_y & (_FPCLASS_PINF | _FPCLASS_NINF)) != 0)) {
28 bool x_negative = (cls_x & _FPCLASS_NINF) != 0;
29 bool y_negative = (cls_y & _FPCLASS_NINF) != 0;
30 static double atans_at_infinities[2][2] =
31 { { atan2(1., 1.), atan2(1., -1.) },
32 { atan2(-1., 1.), atan2(-1., -1.) } };
33 return atans_at_infinities[x_negative][y_negative];
Mads Ager (google) 2012/11/28 09:26:26 Could you index with ints instead of bools here.
aam-me 2012/11/28 12:14:36 Done.
34 } else {
35 return atan2(x, y);
36 }
37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698