base/prefs: Break the dependency in chrome_paths.h

base/prefs: Break the dependency in chrome_paths.h

BUG=155525
TEST=unit_tests --gtest_filter=JsonPrefStoreTest*
R=joi@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169701

[tfarina, 2012-11-24 00:39:48]

Hi Joi, could you review this to me?

Thanks!

https://codereview.chromium.org/11411159/diff/6001/base/prefs/test/data/pref_...
File base/prefs/test/data/pref_service/read.json (right):

https://codereview.chromium.org/11411159/diff/6001/base/prefs/test/data/pref_...
base/prefs/test/data/pref_service/read.json:2: "homepage": "http://www.cnn.com",
Ahh, this is from where kHomePage comes from and
pref_change_registrar_unittest.cc:136

Now makes sense. ;)

[Jói, 2012-11-26 10:42:26]

Thanks Thiago.  One question to resolve.

Cheers,
Jói

https://codereview.chromium.org/11411159/diff/6001/base/prefs/pref_paths.h
File base/prefs/pref_paths.h (right):

https://codereview.chromium.org/11411159/diff/6001/base/prefs/pref_paths.h#ne...
base/prefs/pref_paths.h:17: DIR_TEST_DATA,
Have you seen any other paths that might get added to this set (so that there
are multiple values this enum could take)?  Or other places that need the test
data path?  If neither, I think I would prefer to just build the path in the
unit test code.

[tfarina, 2012-11-27 02:15:59]

Sorry for the delay.

https://codereview.chromium.org/11411159/diff/6001/base/prefs/pref_paths.h
File base/prefs/pref_paths.h (right):

https://codereview.chromium.org/11411159/diff/6001/base/prefs/pref_paths.h#ne...
base/prefs/pref_paths.h:17: DIR_TEST_DATA,
On 2012/11/26 10:42:26, Jói wrote:
> Have you seen any other paths that might get added to this set (so that there
> are multiple values this enum could take)?  Or other places that need the test
> data path?  If neither, I think I would prefer to just build the path in the
> unit test code.

Done.

[Jói, 2012-11-27 08:24:09]

LGTM, although I wonder if the original locations for the test files should also
be deleted?

[commit-bot: I haz the power, 2012-11-27 10:45:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11411159/10001

[commit-bot: I haz the power, 2012-11-27 14:32:20]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is android_dbg, revision is HEAD

[commit-bot: I haz the power, 2012-11-27 16:18:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11411159/2006

[commit-bot: I haz the power, 2012-11-27 19:09:19]

Change committed as 169701