Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(61)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: base/prefs/test/data/pref_service/write.golden.json
Issue
11411159
:
base/prefs: Break the dependency in chrome_paths.h (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add path to fix android
Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
base/prefs/DEPS
base/prefs/json_pref_store_unittest.cc
base/prefs/test/data/pref_service/invalid.json
base/prefs/test/data/pref_service/read.json
base/prefs/test/data/pref_service/read.need_empty_value.json
base/prefs/test/data/pref_service/write.golden.json
base/prefs/test/data/pref_service/write.golden.need_empty_value.json
build/android/pylib/single_test_runner.py
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« base/prefs/test/data/pref_service/read.need_empty_value.json
('k') |
base/prefs/test/data/pref_service/write.golden.need_empty_value.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "homepage": "http://www.cnn.com",
2 "homepage": "http://www.cnn.com",
3 "long_int": {
3 "long_int": {
4 "pref": "214748364842"
4 "pref": "214748364842"
5 },
5 },
6 "some_directory": "/usr/sbin/",
6 "some_directory": "/usr/sbin/",
7 "tabs": {
7 "tabs": {
8 "max_tabs": 10,
8 "max_tabs": 10,
9 "new_windows_in_tabs": false
9 "new_windows_in_tabs": false
10 }
10 }
11 }
11 }
OLD
NEW
« no previous file with comments
|
« base/prefs/test/data/pref_service/read.need_empty_value.json
('k') |
base/prefs/test/data/pref_service/write.golden.need_empty_value.json »
('j') |
no next file with comments »
Issue 11411159: base/prefs: Break the dependency in chrome_paths.h (Closed)
Created 8 years ago by tfarina
Modified 8 years ago
Reviewers: Jói
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 3
This is Rietveld
408576698
Chromium Code Reviews
Issue 11411159:
base/prefs: Break the dependency in chrome_paths.h (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src