Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 11411016: [Mac] Fix issue where rubber-banding may get sporadically stuck. (Closed)

Created:
8 years, 1 month ago by Alexei Svitkine (slow)
Modified:
8 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Mac] Fix issue where rubber-banding may get sporadically stuck. The problem happens due to event coalescing, when there is a buffered PhaseEnd wheel event (because an ACK hasn't yet been received for the previous wheel event), and another event arrives (e.g. such as GestureScrollEnd). In this case, the previous code would clear all the pending wheel events, which caused the PhaseEnd wheel event to never be sent, which results in rubber-banding overhang getting stuck. BUG=154740 TEST=Rubber-banding should not get sporadically stuck randomly during regular two-finger gestures. (There is still an issue with focus switching / mouse leaving from the RWHV, which is separate.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168448

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -12 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 chunks +25 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
8 years, 1 month ago (2012-11-15 21:06:31 UTC) #1
Nico
test?
8 years, 1 month ago (2012-11-15 21:07:51 UTC) #2
Alexei Svitkine (slow)
On 2012/11/15 21:07:51, Nico wrote: > test? Good call. Done. PTAL.
8 years, 1 month ago (2012-11-16 15:04:24 UTC) #3
Nico
lgtm, thanks!
8 years, 1 month ago (2012-11-16 18:25:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11411016/5003
8 years, 1 month ago (2012-11-16 18:31:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11411016/5003
8 years, 1 month ago (2012-11-17 14:14:53 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 15:58:27 UTC) #7
Change committed as 168448

Powered by Google App Engine
This is Rietveld 408576698