Allow zip_build to zip up chrome_dll.pdb OR chrome.dll.pdb

Allow zip_build to zip up chrome_dll.pdb OR chrome.dll.pdb

TBR=nsylvain@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166542

[iannucci, 2012-11-07 21:13:00]

simple change, ptal. This is because I have a bunch of cl's in the pipe to
change the pdb naming convention to be sane (i.e. chrome.dll.pdb instead of
chrome_dll.pdb)

Thanks

[Isaac (away), 2012-11-07 21:39:09]

The code itself looks fine to me, but I'm not an owner.  Nicolas would be a
better contact for this because it potentially affects windows zip sizes.

[Isaac (away), 2012-11-07 21:42:36]

https://chromiumcodereview.appspot.com/11396002/diff/1/scripts/slave/zip_buil...
File scripts/slave/zip_build.py (right):

https://chromiumcodereview.appspot.com/11396002/diff/1/scripts/slave/zip_buil...
scripts/slave/zip_build.py:103: return (r'^(chrome.dll|chrome.exe'
use [._] if you want to match that.  Lets try to avoid using '.' character in
regex.

[iannucci, 2012-11-07 21:53:09]

https://chromiumcodereview.appspot.com/11396002/diff/1/scripts/slave/zip_buil...
File scripts/slave/zip_build.py (right):

https://chromiumcodereview.appspot.com/11396002/diff/1/scripts/slave/zip_buil...
scripts/slave/zip_build.py:103: return (r'^(chrome.dll|chrome.exe'
On 2012/11/07 21:42:39, Isaac wrote:
> use [._] if you want to match that.  Lets try to avoid using '.' character in
> regex.

Done.

[Isaac (away), 2012-11-07 21:55:54]

lgtm

[commit-bot: I haz the power, 2012-11-07 22:06:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11396002/6001

[commit-bot: I haz the power, 2012-11-07 22:08:09]

Presubmit check for 11396002-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    build

Presubmit checks took 80.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[iannucci, 2012-11-07 22:14:06]

@nsylvain need owner lgtm :D

[Isaac (away), 2012-11-07 22:54:30]

I forgot he's gone this week.  I think this patch is benign enough to TBR.

[iannucci, 2012-11-07 23:02:03]

On 2012/11/07 22:54:30, Isaac wrote:
> I forgot he's gone this week.  I think this patch is benign enough to TBR.

Oh right... I knew that. I'll TBR it.

[commit-bot: I haz the power, 2012-11-07 23:02:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11396002/6001

[commit-bot: I haz the power, 2012-11-07 23:04:10]

Change committed as 166542

[nsylvain, 2012-11-12 22:14:16]

lgtm