Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: scripts/slave/zip_build.py

Issue 11396002: Allow zip_build to zip up chrome_dll.pdb OR chrome.dll.pdb (Closed) Base URL: http://git.chromium.org/chromium/tools/build.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ Creates a zip file in the staging dir with the result of a compile. 6 """ Creates a zip file in the staging dir with the result of a compile.
7 It can be sent to other machines for testing. 7 It can be sent to other machines for testing.
8 """ 8 """
9 9
10 import csv 10 import csv
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 raise NotImplementedError('%s is not supported.' % sys.platform) 93 raise NotImplementedError('%s is not supported.' % sys.platform)
94 94
95 return os.path.abspath(os.path.join(*path_list)) 95 return os.path.abspath(os.path.join(*path_list))
96 96
97 97
98 def FileRegexWhitelist(options): 98 def FileRegexWhitelist(options):
99 if chromium_utils.IsWindows() and options.target is 'Release': 99 if chromium_utils.IsWindows() and options.target is 'Release':
100 # Special case for chrome. Add back all the chrome*.pdb files to the list. 100 # Special case for chrome. Add back all the chrome*.pdb files to the list.
101 # Also add browser_test*.pdb, ui_tests.pdb and ui_tests.pdb. 101 # Also add browser_test*.pdb, ui_tests.pdb and ui_tests.pdb.
102 # TODO(nsylvain): This should really be defined somewhere else. 102 # TODO(nsylvain): This should really be defined somewhere else.
103 return (r'^(chrome_dll|chrome_exe' 103 return (r'^(chrome.dll|chrome.exe'
Isaac (away) 2012/11/07 21:42:39 use [._] if you want to match that. Lets try to a
iannucci 2012/11/07 21:53:10 Done.
104 # r'|browser_test.+|unit_tests' 104 # r'|browser_test.+|unit_tests'
105 # r'|chrome_frame_.*tests' 105 # r'|chrome_frame_.*tests'
106 r')\.pdb$') 106 r')\.pdb$')
107 107
108 return '$NO_FILTER^' 108 return '$NO_FILTER^'
109 109
110 110
111 def FileRegexBlacklist(options): 111 def FileRegexBlacklist(options):
112 if chromium_utils.IsWindows(): 112 if chromium_utils.IsWindows():
113 # Remove all .ilk/.7z and maybe PDB files 113 # Remove all .ilk/.7z and maybe PDB files
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 # When option_parser is passed argv as a list, it can return the caller as 360 # When option_parser is passed argv as a list, it can return the caller as
361 # first unknown arg. So throw a warning if we have two or more unknown 361 # first unknown arg. So throw a warning if we have two or more unknown
362 # arguments. 362 # arguments.
363 if args[1:]: 363 if args[1:]:
364 print 'Warning -- unknown arguments' % args[1:] 364 print 'Warning -- unknown arguments' % args[1:]
365 365
366 return Archive(options) 366 return Archive(options)
367 367
368 if '__main__' == __name__: 368 if '__main__' == __name__:
369 sys.exit(main(sys.argv)) 369 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698