Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4610)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_ui_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 47a4a1220f4dff350722d8a8af2b44a302298706..d5dc2b82a6a17db665ae0c77c8fed87a65521189 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -1126,10 +1126,10 @@ void TestingAutomationProvider::OpenNewBrowserWindowOfType(
int type, bool show, IPC::Message* reply_message) {
new BrowserOpenedNotificationObserver(this, reply_message, false);
// We may have no current browser windows open so don't rely on
- // asking an existing browser to execute the IDC_NEWWINDOW command
+ // asking an existing browser to execute the IDC_NEWWINDOW command.
Browser* browser = new Browser(
Browser::CreateParams(static_cast<Browser::Type>(type), profile_));
- chrome::AddBlankTab(browser, true);
+ chrome::AddBlankTabAt(browser, -1, true);
if (show)
browser->window()->Show();
}
@@ -1146,7 +1146,7 @@ void TestingAutomationProvider::OpenNewBrowserWindow(
new BrowserOpenedNotificationObserver(this, reply_message, true);
Browser* browser = new Browser(
Browser::CreateParams(Browser::TYPE_TABBED, profile_));
- chrome::AddBlankTab(browser, true);
+ chrome::AddBlankTabAt(browser, -1, true);
if (show)
browser->window()->Show();
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_ui_default.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698