chrome/browser/ui/tabs/tab_strip_model_delegate.h - Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_delegate.h

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model_delegate.h

diff --git a/chrome/browser/ui/tabs/tab_strip_model_delegate.h b/chrome/browser/ui/tabs/tab_strip_model_delegate.h

index 4facfef16687a948104faf4aa49626a6bd191137..3a8eec6f0cdf8327bcaa229f3dc3c033f36f748f 100644

--- a/chrome/browser/ui/tabs/tab_strip_model_delegate.h

+++ b/chrome/browser/ui/tabs/tab_strip_model_delegate.h

@@ -46,9 +46,9 @@ class TabStripModelDelegate {

virtual ~TabStripModelDelegate() {}

- // Adds what the delegate considers to be a blank tab to the model.

- virtual TabContents* AddBlankTab(bool foreground) = 0;

- virtual TabContents* AddBlankTabAt(int index, bool foreground) = 0;

+ // Adds what the delegate considers to be a blank tab to the model. An |index|

+ // value of -1 means to append the contents to the end of the tab strip.

+ virtual void AddBlankTabAt(int index, bool foreground) = 0;

// Asks for a new TabStripModel to be created and the given web contentses to

// be added to it. Its size and position are reflected in |window_bounds|.