Chromium Code Reviews
Help | Chromium Project | Sign in
(385)

Issue 11377144: add and enable validator tests for x86 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Robert Muth (chromium)
Modified:
1 year, 5 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable validator speed tests for x86.
These are driven by an archived tarball containing
various nexes including spec and translator nexes.
A script for updating the tarball is provided as well.

Also, some script cleanup - e.g. added "readonly"
attribute.



Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10304

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Total comments: 32

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -13 lines) Lint Patch
M buildbot/buildbot_spec2k.sh View 1 2 3 4 5 6 7 8 11 chunks +113 lines, -13 lines 0 comments ? errors Download
A tools/canned_nexe_tool.sh View 1 2 3 4 1 chunk +137 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 14
Robert Muth (chromium)
PTAL @Jan: What is the best way to make the timing output digestable by our ...
1 year, 5 months ago #1
jvoung - send to chromium...
https://chromiumcodereview.appspot.com/11377144/diff/2001/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): https://chromiumcodereview.appspot.com/11377144/diff/2001/buildbot/buildbot_spec2k.sh#newcode161 buildbot/buildbot_spec2k.sh:161: rm -rf CannedNexes Indentation is a bit inconsistent in ...
1 year, 5 months ago #2
Robert Muth (chromium)
As discussed in person we will move the validator tests out of the spec harness ...
1 year, 5 months ago #3
jvoung (cr)
http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode161 buildbot/buildbot_spec2k.sh:161: ${UP_DOWN_LOAD} DownloadArchivedNexes ${CANNED_NEXE_REV} \ Did you want to reuse ...
1 year, 5 months ago #4
jvoung (cr)
http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode171 buildbot/buildbot_spec2k.sh:171: echo "$(pwd)/scons-out/opt-linux-x86-32/staging/ncval" Also, would the dfa-validator devs be interested ...
1 year, 5 months ago #5
robertm
+khim PTAL http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode164 buildbot/buildbot_spec2k.sh:164: rm -rf CannedNexes On 2012/11/15 19:10:48, jvoung ...
1 year, 5 months ago #6
jvoung (cr)
http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode195 buildbot/buildbot_spec2k.sh:195: --output >(LogTimeHelper ${graph} ${benchmark} ${variant}) \ Does --output need ...
1 year, 5 months ago #7
jvoung (cr)
http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode257 buildbot/buildbot_spec2k.sh:257: run-tests SetupPnaclTranslatorX8632Opt "${TRYBOT_TRANSLATOR_TESTS}" 0 1 Perhaps add it to ...
1 year, 5 months ago #8
robertm
PTAL http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh File buildbot/buildbot_spec2k.sh (right): http://codereview.chromium.org/11377144/diff/11002/buildbot/buildbot_spec2k.sh#newcode195 buildbot/buildbot_spec2k.sh:195: --output >(LogTimeHelper ${graph} ${benchmark} ${variant}) \ added a ...
1 year, 5 months ago #9
jvoung (cr)
lgtm
1 year, 5 months ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/robertm@chromium.org/11377144/27007
1 year, 5 months ago #11
I haz the power (commit-bot)
Try job failure for 11377144-27007 (retry) on nacl-lucid_64-newlib-x86_64-pnacl-spec for steps "annotate, validator speed test [x86-64], ...
1 year, 5 months ago #12
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/robertm@chromium.org/11377144/35011
1 year, 5 months ago #13
I haz the power (commit-bot)
1 year, 5 months ago #14
Change committed as 10304
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6