Issue 11369247: Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369247: Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list instead. (Closed)

Created:
8 years, 1 month ago by Bernhard Bauer

Modified:
8 years, 1 month ago

Reviewers:
marja

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list instead. In the old version, removing the plug-in would modify the contents of the passed in parameter (which is a reference!), so we would keep on removing other plug-ins after it. Face, meet palm. BUG=159896 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167979

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -21 lines)			Patch
M	webkit/plugins/npapi/plugin_list.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11369247/1

8 years, 1 month ago (2012-11-15 17:25:00 UTC) #3

Change committed as 167979

Expand Messages | Collapse Messages