Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: webkit/plugins/npapi/plugin_list_win.cc

Issue 11369247: Remove PluginList::RemovePlugin() and directly remove old plug-ins from plug-in list instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_list.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_list_win.cc
diff --git a/webkit/plugins/npapi/plugin_list_win.cc b/webkit/plugins/npapi/plugin_list_win.cc
index c7e494a0abf29ca30bb183eaf1d8bc07f3f6904c..a2d76b810e847395b3953321044b920f6019da7a 100644
--- a/webkit/plugins/npapi/plugin_list_win.cc
+++ b/webkit/plugins/npapi/plugin_list_win.cc
@@ -348,7 +348,7 @@ bool PluginList::ShouldLoadPluginUsingPluginList(
(plugin1 == kJavaDeploy2 && plugin2 == kJavaDeploy1)) {
if (!IsNewerVersion((*plugins)[j].version, info.version))
return false; // We have loaded a plugin whose version is newer.
- PluginList::RemovePlugin((*plugins)[j].path, plugins);
+ plugins->erase(plugins->begin() + j);
break;
}
}
@@ -398,7 +398,7 @@ bool PluginList::ShouldLoadPluginUsingPluginList(
for (size_t j = 0; j < plugins->size(); ++j) {
if ((*plugins)[j].path.BaseName().value() == kOldWMPPlugin) {
- PluginList::RemovePlugin((*plugins)[j].path, plugins);
+ plugins->erase(plugins->begin() + j);
break;
}
}
« no previous file with comments | « webkit/plugins/npapi/plugin_list.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698