Issue 11369130: [cc] Tiles and tile manager for impl side painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369130: [cc] Tiles and tile manager for impl side painting (Closed)

Created:
8 years, 1 month ago by nduca

Modified:
8 years, 1 month ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cc] Tiles and tile manager for impl side painting BUG=155209 R=enne@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166787

Patch Set 2 : fixen #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -0 lines)			Patch
M	cc/cc.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	cc/tile.h	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	cc/tile.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	cc/tile_manager.h	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	cc/tile_manager.cc	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	cc/tile_priority.h	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

lgtm https://codereview.chromium.org/11369130/diff/1/cc/tile.h File cc/tile.h (right): https://codereview.chromium.org/11369130/diff/1/cc/tile.h#newcode31 cc/tile.h:31: void SetPicturePile(int frame_number, scoped_refptr<PicturePile> picture_pile) {} I have ...

8 years, 1 month ago (2012-11-08 17:16:50 UTC) #2

enne (OOO)

I'd hit CQ, but it looks like you have some legit build errors.

8 years, 1 month ago (2012-11-08 17:17:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11369130/9005

8 years, 1 month ago (2012-11-08 19:43:01 UTC) #4

Change committed as 166787

Expand Messages | Collapse Messages

Issue 11369130: [cc] Tiles and tile manager for impl side painting (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixen #

Messages