Use correct restore bounds in resizer.

Use correct restore bounds in resizer.

BUG=none
TEST=coverted by test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165571

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165820

[sky, 2012-11-01 16:34:35]

https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:69: gfx::Rect initial_bounds;
How come we need to track both bounds in parent and screen bounds?

https://codereview.chromium.org/11369017/diff/8009/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

https://codereview.chromium.org/11369017/diff/8009/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:536: }
Put the break inside the {} and move } in two spaces. See browser.cc for
examples of how we typically deal with this.

[oshima, 2012-11-01 18:11:35]

https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:69: gfx::Rect initial_bounds;
On 2012/11/01 16:34:35, sky wrote:
> How come we need to track both bounds in parent and screen bounds?
I originally thought it's more readable, but it wasn't bad, so removed.

https://codereview.chromium.org/11369017/diff/8009/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

https://codereview.chromium.org/11369017/diff/8009/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:536: }
On 2012/11/01 16:34:35, sky wrote:
> Put the break inside the {} and move } in two spaces. See browser.cc for
> examples of how we typically deal with this.

done. (original change was just indentation change by emacs,
which rietveld somehow failed to show it correctly)

[sky, 2012-11-01 21:34:48]

LGTM

[commit-bot: I haz the power, 2012-11-01 22:17:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11369017/2002

[commit-bot: I haz the power, 2012-11-02 00:20:42]

Change committed as 165571

[kinuko, 2012-11-02 08:03:09]

fyi, the WorkspaceWindowResizerTest.Edge test seems to be failing on win aura
bot after this change. (I'll leave it as the bot's not a closer)

[phoglund_chromium, 2012-11-02 10:13:23]

On 2012/11/02 08:03:09, kinuko wrote:
> fyi, the WorkspaceWindowResizerTest.Edge test seems to be failing on win aura
> bot after this change. (I'll leave it as the bot's not a closer)

Ok, since kinuko decided to not roll back I will not either :) I'll disable the
test for now in https://codereview.chromium.org/11365063. Please re-enable the
test when you fix this!

[commit-bot: I haz the power, 2012-11-02 22:51:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11369017/4002

[commit-bot: I haz the power, 2012-11-03 00:53:34]

Change committed as 165820