Chromium Code Reviews
Help | Chromium Project | Sign in
(769)

Issue 11369017: Use correct restore bounds in resizer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by oshima (OOO April 11 - 21)
Modified:
1 year, 5 months ago
Reviewers:
sky
CC:
chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use correct restore bounds in resizer.

BUG=none
TEST=coverted by test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165571

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165820

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -45 lines) Lint Patch
M ash/wm/default_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/wm/window_resizer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M ash/wm/window_resizer.cc View 1 2 3 11 chunks +26 lines, -22 lines 0 comments 0 errors Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 4 chunks +11 lines, -8 lines 0 comments 0 errors Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 1 chunk +39 lines, -9 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 10
oshima (OOO April 11 - 21)
1 year, 5 months ago #1
sky
https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h File ash/wm/window_resizer.h (right): https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h#newcode69 ash/wm/window_resizer.h:69: gfx::Rect initial_bounds; How come we need to track both ...
1 year, 5 months ago #2
oshima (OOO April 11 - 21)
https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h File ash/wm/window_resizer.h (right): https://codereview.chromium.org/11369017/diff/8009/ash/wm/window_resizer.h#newcode69 ash/wm/window_resizer.h:69: gfx::Rect initial_bounds; On 2012/11/01 16:34:35, sky wrote: > How ...
1 year, 5 months ago #3
sky
LGTM
1 year, 5 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11369017/2002
1 year, 5 months ago #5
I haz the power (commit-bot)
Change committed as 165571
1 year, 5 months ago #6
kinuko
fyi, the WorkspaceWindowResizerTest.Edge test seems to be failing on win aura bot after this change. ...
1 year, 5 months ago #7
phoglund
On 2012/11/02 08:03:09, kinuko wrote: > fyi, the WorkspaceWindowResizerTest.Edge test seems to be failing on ...
1 year, 5 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11369017/4002
1 year, 5 months ago #9
I haz the power (commit-bot)
1 year, 5 months ago #10
Change committed as 165820
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434