Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 11368142: Turn message property of the error object into a data property. (Closed)

Created:
8 years, 1 month ago by Yang
Modified:
8 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Turn message property of the error object into a data property. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12908

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -222 lines) Patch
M src/messages.cc View 1 chunk +4 lines, -1 line 1 comment Download
M src/messages.js View 5 chunks +135 lines, -178 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -27 lines 0 comments Download
A + test/mjsunit/error-accessors.js View 1 chunk +21 lines, -13 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
8 years, 1 month ago (2012-11-08 15:26:14 UTC) #1
Yang
On 2012/11/08 15:26:14, Yang wrote: This change includes: - Format the message string when the ...
8 years, 1 month ago (2012-11-08 15:29:57 UTC) #2
Sven Panne
8 years, 1 month ago (2012-11-09 07:55:07 UTC) #3
LGTM with a nit

http://codereview.chromium.org/11368142/diff/1/src/messages.cc
File src/messages.cc (right):

http://codereview.chromium.org/11368142/diff/1/src/messages.cc#newcode158
src/messages.cc:158: ASSERT(data->IsJSMessageObject());
No need for this ASSERT, all cast methods do this implicitly.

Powered by Google App Engine
This is Rietveld 408576698