src/messages.cc - Issue 11368142: Turn message property of the error object into a data property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 11368142: Turn message property of the error object into a data property. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 23fd4fd5d866f1aecef5cc6c7a0eb16d647230b9..e4a1ff7a1cf7b60310c1f1485e8bfdc0c3111526 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -155,7 +155,10 @@ Handle<String> MessageHandler::GetMessage(Handle<Object> data) {

JSFunction::cast(

Isolate::Current()->js_builtins_object()->

GetPropertyNoExceptionThrown(*fmt_str)));

- Handle<Object> argv[] = { data };

+ ASSERT(data->IsJSMessageObject());

Sven Panne 2012/11/09 07:55:07 No need for this ASSERT, all cast methods do this

+ Handle<JSMessageObject> message = Handle<JSMessageObject>::cast(data);

+ Handle<Object> argv[] = { Handle<Object>(message->type()),

+ Handle<Object>(message->arguments()) };

bool caught_exception;

Handle<Object> result =

« no previous file with comments | « no previous file | src/messages.js » ('j') | no next file with comments »