Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11368063: cc: Fix header include guards of our header files. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
danakj, jamesr, enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix header include guards of our header files. Fixed with a hacky python script :/ BUG=144576, 144577 TEST=$ cpplint.py cc/*.h 2>&1 | grep header_guard. And verified it doesn't complain. R=enne@chromium.org,jamesr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165895

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix cc/test as well #

Patch Set 4 : rm CCLayerTreeTestCommon.h #

Patch Set 5 : fix completion_event.h and settings.h #

Total comments: 3

Patch Set 6 : revert copyright change in completion_event.h #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -420 lines) Patch
M cc/active_animation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/animation_curve.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/animation_events.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/append_quads_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/bitmap_content_layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/bitmap_skpicture_content_layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/caching_bitmap_content_layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/checkerboard_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/completion_event.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M cc/content_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/content_layer_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/content_layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/contents_scaling_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/damage_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/debug_border_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/debug_rect_history.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/delay_based_time_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/delegated_renderer_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/delegated_renderer_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/direct_renderer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/font_atlas.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/frame_rate_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/frame_rate_counter.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/geometry.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/geometry_binding.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/gl_renderer.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/graphics_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/heads_up_display_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/heads_up_display_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/image_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/input_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/io_surface_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/io_surface_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/io_surface_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/keyframed_animation_curve.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_animation_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_iterator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_painter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_sorter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tiling_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tree_host.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tree_host_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tree_host_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/managed_memory_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/math_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/occlusion_tracker.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/overdraw_metrics.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/page_scale_animation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/platform_color.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/prioritized_texture.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
cc/prioritized_texture_manager.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/priority_calculator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/program_binding.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/proxy.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/quad_culler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/quad_sink.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/rate_limiter.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_pass.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_pass_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_pass_sink.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_surface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_surface_filters.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/render_surface_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/renderer.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/rendering_stats.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resource_provider.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resource_update_controller.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resource_update_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler_state_machine.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scoped_texture.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scoped_thread_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scrollbar_animation_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
cc/scrollbar_animation_controller_linear_fade.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scrollbar_geometry_fixed_thumb.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scrollbar_geometry_stub.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scrollbar_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/scrollbar_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/settings.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/shader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/shared_quad_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/single_thread_proxy.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/skpicture_content_layer_updater.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/software_renderer.h View 2 chunks +3 lines, -3 lines 0 comments Download
cc/solid_color_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/solid_color_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/solid_color_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/stream_video_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
D cc/test/CCLayerTreeTestCommon.h View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
M cc/test/animation_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/compositor_fake_web_graphics_context_3d.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_graphics_context.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_web_compositor_output_surface.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_web_compositor_software_output_device.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_web_scrollbar_theme_geometry.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/geometry_test_utils.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M cc/test/mock_quad_culler.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/occlusion_tracker_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/render_pass_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
cc/test/scheduler_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_copier.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/texture_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/thread_proxy.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tile_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
cc/time_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/timing_function.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tree_synchronizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/video_layer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/video_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/yuv_video_draw_quad.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
8 years, 1 month ago (2012-11-02 23:48:59 UTC) #1
danakj
http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h File cc/completion_event.h (right): http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h#newcode1 cc/completion_event.h:1: // Copyright 2012 The Chromium Authors. All rights reserved. ...
8 years, 1 month ago (2012-11-02 23:49:53 UTC) #2
tfarina
http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h File cc/completion_event.h (right): http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h#newcode1 cc/completion_event.h:1: // Copyright 2012 The Chromium Authors. All rights reserved. ...
8 years, 1 month ago (2012-11-02 23:52:21 UTC) #3
danakj
lgtm other than that year change.
8 years, 1 month ago (2012-11-02 23:54:28 UTC) #4
tfarina
http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h File cc/completion_event.h (right): http://codereview.chromium.org/11368063/diff/9001/cc/completion_event.h#newcode1 cc/completion_event.h:1: // Copyright 2012 The Chromium Authors. All rights reserved. ...
8 years, 1 month ago (2012-11-02 23:55:07 UTC) #5
enne (OOO)
lgtm2
8 years, 1 month ago (2012-11-03 00:44:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11368063/9002
8 years, 1 month ago (2012-11-05 01:31:21 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 04:12:44 UTC) #8 
Change committed as 165895

Powered by Google App Engine
This is Rietveld 408576698