Issue 11367105: Put incremental code flushing behind a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11367105: Put incremental code flushing behind a flag. (Closed)

Created:
8 years, 1 month ago by Michael Starzinger

Modified:
8 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Put incremental code flushing behind a flag. This is used to disable incremental code flushing by default for now until we can stabilize it and make it ready for production. R=verwaest@chromium.org BUG=chromium:159140 Committed: https://code.google.com/p/v8/source/detail?r=12862

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Toon Verwaest. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
M	src/flag-definitions.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/heap.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/mark-compact.cc	View		3 chunks	+17 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h#newcode398 src/flag-definitions.h:398: "flush code that we expect not ...

8 years, 1 month ago (2012-11-06 11:49:16 UTC) #2

Michael Starzinger

8 years, 1 month ago (2012-11-06 11:51:22 UTC) #3

Addressed comments. Landing.

https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h...
src/flag-definitions.h:398: "flush code that we expect not to use again
incrementally")
On 2012/11/06 11:49:16, Toon Verwaest wrote:
> ... again (full gc).
> ... again (incrementally).

Done.

Expand Messages | Collapse Messages