Chromium Code Reviews
Help | Chromium Project | Sign in
(202)

Issue 11367105: Put incremental code flushing behind a flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Michael Starzinger
Modified:
1 year, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Put incremental code flushing behind a flag.

This is used to disable incremental code flushing by default for now
until we can stabilize it and make it ready for production.

R=verwaest@chromium.org
BUG=chromium:159140
Committed: https://code.google.com/p/v8/source/detail?r=12862

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Toon Verwaest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Lint Patch
M src/flag-definitions.h View 1 1 chunk +3 lines, -1 line 0 comments 1 errors Download
M src/heap.cc View 1 chunk +2 lines, -6 lines 0 comments ? errors Download
M src/mark-compact.cc View 3 chunks +17 lines, -0 lines 0 comments 0 errors Download
M test/cctest/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Michael Starzinger
1 year, 5 months ago #1
Toon Verwaest
lgtm with nit https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h#newcode398 src/flag-definitions.h:398: "flush code that we expect not ...
1 year, 5 months ago #2
Michael Starzinger
1 year, 5 months ago #3
Addressed comments. Landing.

https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://chromiumcodereview.appspot.com/11367105/diff/1/src/flag-definitions.h...
src/flag-definitions.h:398: "flush code that we expect not to use again
incrementally")
On 2012/11/06 11:49:16, Toon Verwaest wrote:
> ... again (full gc).
> ... again (incrementally).

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6