Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issue 11367082: Add QuicStream and friends to QUIC code. (Closed)

Created:
8 years, 1 month ago by Ryan Hamilton
Modified:
8 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add QuicStream and friends to QUIC code. Fix bug in tests that caused failures. Revert 165859 First Landed as 165858 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165864

Patch Set 1 : Base from Issue 11300020 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1714 lines, -2 lines) Patch
M net/net.gyp View 3 chunks +11 lines, -0 lines 0 comments Download
A net/quic/quic_crypto_stream.h View 1 chunk +59 lines, -0 lines 0 comments Download
A net/quic/quic_crypto_stream.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A net/quic/quic_crypto_stream_test.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A net/quic/quic_session.h View 1 chunk +117 lines, -0 lines 0 comments Download
A net/quic/quic_session.cc View 1 chunk +195 lines, -0 lines 0 comments Download
A net/quic/quic_session_test.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A net/quic/quic_stream_sequencer.h View 1 chunk +90 lines, -0 lines 0 comments Download
A net/quic/quic_stream_sequencer.cc View 1 chunk +203 lines, -0 lines 0 comments Download
A net/quic/quic_stream_sequencer_test.cc View 1 1 chunk +413 lines, -0 lines 0 comments Download
A net/quic/reliable_quic_stream.h View 1 chunk +80 lines, -0 lines 0 comments Download
A net/quic/reliable_quic_stream.cc View 1 chunk +126 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +75 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Hamilton
Hi Guys, Can one of you LGTM this change? Patch set 1 is a change ...
8 years, 1 month ago (2012-11-03 17:58:15 UTC) #1
willchan no longer on Chromium
lgtm
8 years, 1 month ago (2012-11-03 18:02:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11367082/6001
8 years, 1 month ago (2012-11-03 18:02:48 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-04 00:03:31 UTC) #4
Change committed as 165864

Powered by Google App Engine
This is Rietveld 408576698