Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 11367033: "Using" cleanup. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Code cleanup. No functional changes. Removed unnecessary using declarations in print_web_view_helper.cc. Removed unnecessary print_params_ from context. BUG=152893 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165517

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -153 lines) Patch
M chrome/renderer/print_web_view_helper.h View 8 chunks +12 lines, -10 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 41 chunks +111 lines, -132 lines 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/print_web_view_helper_mac.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vitaly Buka (NO REVIEWS)
Hello Lei, can you approve change? I extracted this from CL with real changes, to ...
6 years, 8 months ago (2012-11-01 18:57:07 UTC) #1
Lei Zhang
lgtm Thanks for cleaning up a lot of cruft that have build up over time. ...
6 years, 8 months ago (2012-11-01 19:21:42 UTC) #2
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/11367033/diff/11002/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (left): https://chromiumcodereview.appspot.com/11367033/diff/11002/chrome/renderer/print_web_view_helper.cc#oldcode737 chrome/renderer/print_web_view_helper.cc:737: WebKit::WebFrame* frame, bool user_initiated) { On 2012/11/01 19:21:42, Lei ...
6 years, 8 months ago (2012-11-01 19:55:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11367033/14002
6 years, 8 months ago (2012-11-01 19:57:21 UTC) #4
Lei Zhang
lgtm++
6 years, 8 months ago (2012-11-01 19:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/11367033/14003
6 years, 8 months ago (2012-11-01 19:58:13 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2012-11-01 22:09:05 UTC) #7
Change committed as 165517

Powered by Google App Engine
This is Rietveld 408576698