Prevents windows in chromeos from resizing bigger than their maximum size.

Makes windows obey their maximum size constraints on chromeos.

- Prevents windows from resizing bigger than their max size
- Prevents windows from snapping when they have max size defined
- Prevents windows from maximizing when they have max size defined


BUG=152065
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168447

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169402

[sky, 2012-11-13 17:29:40]

You also need to deal with window snapping and layout of attached windows.

I'm adding Stefan on the cc list for this as he's adding support for properly
dealing with windows that aren't resizable at all.

[koz (OOO until 15th September), 2012-11-14 00:42:38]

On 2012/11/13 17:29:40, sky wrote:
> You also need to deal with window snapping and layout of attached windows.
> 
> I'm adding Stefan on the cc list for this as he's adding support for properly
> dealing with windows that aren't resizable at all.

Cool, thanks. I've changed the definition of ShellWindowViews::CanMaximize() to
disable maximise / snap to left / snap to right when a window has a max size
defined. Is this what you meant by window snapping?

Stefan, if you're going to add support for windows that aren't resizable at all,
could you also consider the case where windows have constraints on their min/max
size?

Scott, in either case, is this okay to land this patch without handling the
attached windows case?

[Mr4D (OOO till 08-26), 2012-11-14 01:09:32]

My CL has landed now.

I have seen that a constraint for the minimum size - however I have not seen a
constrained for the maximum size.

If you want I can add that of course. :)

[sky, 2012-11-14 02:40:27]

If you're going to fix the attached case and snapping code soon after, I'm ok
with that landing in another patch. Is that the case?

[sky, 2012-11-14 02:40:48]

That said, you do need some test coverage in this patch.

[koz (OOO until 15th September), 2012-11-14 06:24:26]

On 2012/11/14 02:40:48, sky wrote:
> That said, you do need some test coverage in this patch.

Okay, I've added some unit tests and fixed snapping (see the updated description
for more).

Stefan, if you're keen to handle min/max sizes for attached windows that'd be
awesome :-)

[sky, 2012-11-14 14:55:09]

LGTM - follow up with Stefan to make sure one of you deal with the attached
case.

[jeremya, 2012-11-15 01:12:43]

https://codereview.chromium.org/11366215/diff/6014/ash/wm/window_resizer.cc
File ash/wm/window_resizer.cc (right):

https://codereview.chromium.org/11366215/diff/6014/ash/wm/window_resizer.cc#n...
ash/wm/window_resizer.cc:328: if (!max_size.IsEmpty())
Perhaps you only want to check the max width here? A window can have a max width
without having a max height, and size.IsEmpty() returns true if *either* of the
width/height are 0.

https://codereview.chromium.org/11366215/diff/6014/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11366215/diff/6014/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:758: if
(!window()->delegate()->GetMaximumSize().IsEmpty())
Maybe abstract this into ash::wm::CanSnapWindow() (in ash/wm/window_util.h)?

[koz (OOO until 15th September), 2012-11-15 02:46:12]

https://codereview.chromium.org/11366215/diff/6014/ash/wm/window_resizer.cc
File ash/wm/window_resizer.cc (right):

https://codereview.chromium.org/11366215/diff/6014/ash/wm/window_resizer.cc#n...
ash/wm/window_resizer.cc:328: if (!max_size.IsEmpty())
On 2012/11/15 01:12:43, jeremya wrote:
> Perhaps you only want to check the max width here? A window can have a max
width
> without having a max height, and size.IsEmpty() returns true if *either* of
the
> width/height are 0.

Good catch. Fixed here and below.

https://codereview.chromium.org/11366215/diff/6014/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11366215/diff/6014/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:758: if
(!window()->delegate()->GetMaximumSize().IsEmpty())
On 2012/11/15 01:12:43, jeremya wrote:
> Maybe abstract this into ash::wm::CanSnapWindow() (in ash/wm/window_util.h)?

Done.

[commit-bot: I haz the power, 2012-11-15 02:58:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11366215/14001

[commit-bot: I haz the power, 2012-11-15 03:39:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-15 23:24:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11366215/15001

[commit-bot: I haz the power, 2012-11-16 00:04:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-16 01:26:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11366215/18002

[commit-bot: I haz the power, 2012-11-17 14:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11366215/18002

[commit-bot: I haz the power, 2012-11-17 15:57:22]

Change committed as 168447

[jeremya, 2012-11-22 01:34:33]

re-opening because this got reverted.

[commit-bot: I haz the power, 2012-11-26 02:06:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/11366215/26004

[commit-bot: I haz the power, 2012-11-26 04:11:40]

Change committed as 169402