Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 11366058: - Prepopulate the keyword symbol table otherwise we can end up (Closed)

Created:
8 years, 1 month ago by Ivan Posva
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Prepopulate the keyword symbol table otherwise we can end up with empty spots when reading from a snapshot. Committed: https://code.google.com/p/dart/source/detail?r=14453

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M runtime/vm/scanner.cc View 2 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
This avoids crashing when loading the dart2js snapshot. -Ivan
8 years, 1 month ago (2012-11-02 07:23:04 UTC) #1
Mads Ager (google)
LGTM
8 years, 1 month ago (2012-11-02 07:24:24 UTC) #2
hausner
8 years, 1 month ago (2012-11-02 16:35:18 UTC) #3
LGTM

https://chromiumcodereview.appspot.com/11366058/diff/1/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

https://chromiumcodereview.appspot.com/11366058/diff/1/runtime/vm/scanner.cc#...
runtime/vm/scanner.cc:24: object_store->InitKeywordTable();
Looking at this code now I see that ObjectStore::InitKeywordTable basically just
allocates the array. I think we can simplify this. I'll put it on my todo list.

Powered by Google App Engine
This is Rietveld 408576698