Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 11366052: Enable PlatformAppBrowserTest.DevToolsOpenedWithReload for debug builds. (Closed)

Created:
8 years, 1 month ago by tapted
Modified:
8 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable PlatformAppBrowserTest.DevToolsOpenedWithReload for debug builds. Webkit Roll in r165534 and fix in https://bugs.webkit.org/show_bug.cgi?id=100930 (WebKit revision 133188) means that this test will no longer cause a segfault on Debug builds due to http://crbug.com/157097. BUG=158283 TEST=browser_tests --gtest_filter=PlatformAppBrowserTest.DevToolsOpenedWithReload Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/extensions/platform_app_browsertest.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
debug trybots are slooow - and they don't seem to have their own lkgr. But ...
8 years, 1 month ago (2012-11-02 06:01:23 UTC) #1
benwells
lgtm
8 years, 1 month ago (2012-11-02 06:50:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/11366052/1
8 years, 1 month ago (2012-11-02 20:59:43 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 00:34:17 UTC) #4
Change committed as 165808

Powered by Google App Engine
This is Rietveld 408576698