Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 11366052: Enable PlatformAppBrowserTest.DevToolsOpenedWithReload for debug builds. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc
index 2615e82d5b1c4c53f0f31ed6ea40de2bfc33bb9b..7381808940ecd89d5eeef7960108c1262090fc80 100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -707,17 +707,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, RunningAppsAreRecorded) {
}
// Tests that relaunching an app with devtools open reopens devtools.
-#ifdef NDEBUG
-#define MAYBE_DevToolsOpenedWithReload DevToolsOpenedWithReload
-#else
-// This is currently expected to fail in debug builds due to a segfault in
-// WebKit triggered by a dereference between #ifndef NDEBUG guards see
-// http://crbug.com/157097 .
-// The test is disabled because of timeouts, see http://crbug.com/158283.
-#define MAYBE_DevToolsOpenedWithReload DISABLED_DevToolsOpenedWithReload
-#endif
-
-IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_DevToolsOpenedWithReload) {
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DevToolsOpenedWithReload) {
using content::DevToolsAgentHostRegistry;
ExtensionTestMessageListener launched_listener("Launched", false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698