Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: ppapi/cpp/dev/audio_input_dev.h

Issue 11366038: Rewrite PPB_AudioInput_Dev to use the new-style host/resource. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/trusted/ppb_audio_input_trusted_dev.h ('k') | ppapi/cpp/dev/audio_input_dev.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/dev/audio_input_dev.h
diff --git a/ppapi/cpp/dev/audio_input_dev.h b/ppapi/cpp/dev/audio_input_dev.h
index 1c80f4db5ee4fd07c15277cec02f865bc823263d..fc336a946f750e5c8cce65f6e73d59adea631052 100644
--- a/ppapi/cpp/dev/audio_input_dev.h
+++ b/ppapi/cpp/dev/audio_input_dev.h
@@ -22,20 +22,7 @@ class AudioInput_Dev : public Resource {
/// An empty constructor for an AudioInput resource.
AudioInput_Dev();
- /// This constructor tries to create an audio input resource using the v0.2
- /// interface, and falls back on the v0.1 interface if that is not available.
- /// Please use the 2-parameter Open() if you used this constructor.
- ///
- /// Note: This constructor is deprecated. Unless your code has to deal with
- /// browsers that only support the v0.1 interface, please use the 1-parameter
- /// constructor instead.
- AudioInput_Dev(const InstanceHandle& instance,
- const AudioConfig& config,
- PPB_AudioInput_Callback callback,
- void* user_data);
-
- /// This constructor uses the v0.2 interface to create an audio input
- /// resource. Please use the 5-parameter Open() if you used this constructor.
+ /// Constructor to create an audio input resource.
explicit AudioInput_Dev(const InstanceHandle& instance);
virtual ~AudioInput_Dev();
@@ -46,35 +33,12 @@ class AudioInput_Dev : public Resource {
/// @return true if the interface is available, false otherwise.
static bool IsAvailable();
- /// Getter function for returning the internal <code>PPB_AudioConfig</code>
- /// struct.
- ///
- /// @return A mutable reference to the PPB_AudioConfig struct.
- AudioConfig& config() { return config_; }
-
- /// Getter function for returning the internal <code>PPB_AudioConfig</code>
- /// struct.
- ///
- /// @return A const reference to the internal <code>PPB_AudioConfig</code>
- /// struct.
- const AudioConfig& config() const { return config_; }
-
int32_t EnumerateDevices(
const CompletionCallbackWithOutput<std::vector<DeviceRef_Dev> >&
callback);
/// If |device_ref| is null (i.e., is_null() returns true), the default device
/// will be used.
- /// In order to maintain backward compatibility, this method doesn't have
- /// input parameters config, audio_input_callback and user_data. Instead, it
- /// uses those values stored when the 4-parameter constructor was called.
- ///
- /// Note: This method is deprecated. Unless your code has to deal with
- /// browsers that only support the v0.1 interface, please use the other
- /// Open().
- int32_t Open(const DeviceRef_Dev& device_ref,
- const CompletionCallback& callback);
-
int32_t Open(const DeviceRef_Dev& device_ref,
const AudioConfig& config,
PPB_AudioInput_Callback audio_input_callback,
@@ -84,13 +48,6 @@ class AudioInput_Dev : public Resource {
bool StartCapture();
bool StopCapture();
void Close();
-
- private:
- AudioConfig config_;
-
- // Used to store the arguments of Open() for the v0.2 interface.
- PPB_AudioInput_Callback audio_input_callback_;
- void* user_data_;
};
} // namespace pp
« no previous file with comments | « ppapi/c/trusted/ppb_audio_input_trusted_dev.h ('k') | ppapi/cpp/dev/audio_input_dev.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698