Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 11365249: drive: Event logger for chrome:drive-internals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by kinaba
Modified:
2 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, arv, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Event logger for chrome:drive-internals. BUG=158005 TEST=Open chrome:drive-internals, and verify "Event Log" section is added. TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167647

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Review fix (#2, #3). #

Total comments: 8

Patch Set 3 : Review fix (#5) #

Messages

Total messages: 9 (0 generated)
kinaba
2 years, 4 months ago (2012-11-14 05:42:30 UTC) #1
satorux1
http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h File chrome/browser/chromeos/drive/event_logger.h (right): http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 chrome/browser/chromeos/drive/event_logger.h:16: class EventLogger { Class comment is missing. http://codereview.chromium.org/11365249/diff/1009/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc File ...
2 years, 4 months ago (2012-11-14 05:55:11 UTC) #2
satorux1
On 2012/11/14 05:55:11, satorux1 wrote: > http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h > File chrome/browser/chromeos/drive/event_logger.h (right): > > http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 > ...
2 years, 4 months ago (2012-11-14 05:55:51 UTC) #3
kinaba
http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h File chrome/browser/chromeos/drive/event_logger.h (right): http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 chrome/browser/chromeos/drive/event_logger.h:16: class EventLogger { On 2012/11/14 05:55:11, satorux1 wrote: > ...
2 years, 4 months ago (2012-11-14 06:19:52 UTC) #4
satorux1
LGTM with nits http://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc File chrome/browser/chromeos/drive/event_logger.cc (right): http://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc#newcode24 chrome/browser/chromeos/drive/event_logger.cc:24: history_.push_back(Event(next_event_id_++, what)); Let's increment this on ...
2 years, 4 months ago (2012-11-14 07:59:30 UTC) #5
kinaba
https://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc File chrome/browser/chromeos/drive/event_logger.cc (right): https://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc#newcode24 chrome/browser/chromeos/drive/event_logger.cc:24: history_.push_back(Event(next_event_id_++, what)); On 2012/11/14 07:59:30, satorux1 wrote: > Let's ...
2 years, 4 months ago (2012-11-14 08:13:35 UTC) #6
kinaba
TRBing sky@ for chrome/*.gyp change.
2 years, 4 months ago (2012-11-14 09:54:55 UTC) #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/11365249/12003
2 years, 4 months ago (2012-11-14 09:55:13 UTC) #8
I haz the power (commit-bot)
2 years, 4 months ago (2012-11-14 10:59:35 UTC) #9
Change committed as 167647
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d