Chromium Code Reviews
Help | Chromium Project | Sign in
(1172)

Issue 11365221: Allow property indexes to refer to slots inside the object header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Massi
Modified:
1 year, 5 months ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Allow property indexes to refer to slots inside the object header.

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12944

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -83 lines) Lint Patch
M src/arm/stub-cache-arm.cc View 3 chunks +17 lines, -12 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +19 lines, -14 lines 0 comments 0 errors Download
M src/ic.cc View 3 chunks +5 lines, -7 lines 0 comments 0 errors Download
M src/json-stringifier.h View 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/mips/stub-cache-mips.cc View 2 chunks +16 lines, -11 lines 0 comments 0 errors Download
M src/objects.cc View 4 chunks +7 lines, -4 lines 0 comments 0 errors Download
M src/property.h View 3 chunks +42 lines, -3 lines 5 comments ? errors Download
M src/property.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/runtime.cc View 5 chunks +7 lines, -6 lines 0 comments ? errors Download
M src/stub-cache.h View 8 chunks +8 lines, -8 lines 0 comments ? errors Download
M src/stub-cache.cc View 3 chunks +3 lines, -3 lines 0 comments ? errors Download
M src/x64/stub-cache-x64.cc View 1 chunk +15 lines, -10 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Massi
This small refactory is needed to make so that array length access ICs can use ...
1 year, 5 months ago #1
Jakob
1 year, 5 months ago #2
LGTM with a bunch of nits.

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h
File src/property.h (right):

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h#newcode135
src/property.h:135: // Hold a property index value distinguishing if it is a
field index or an
nit: s/Hold/Holds/

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h#newcode146
src/property.h:146: bool IsFieldIndex() { return (index_ & kHeaderIndexBit) ==
0; }
nit: I think for this and the next three methods, unix_hacker_style names would
be appropriate, as they're essentially simple getters.

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h#newcode158
src/property.h:158: int RawIndex() { return index_; }
I don't see this ever getting called.

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h#newcode167
src/property.h:167: PropertyIndex(int index, bool isHeaderBased) :
nit1: ':' should be on the second line (see e.g. the LookupResult constructor
right below).

nit2: is_header_based. (Usually, we also prefer enums over bools, but since this
method is local to the class, using a bool is OK.)

nit3: within the "private:" section, please adhere to the ordering statics ->
methods -> fields.

https://chromiumcodereview.appspot.com/11365221/diff/1/src/property.h#newcode172
src/property.h:172: 
nit: two lines of whitespace between top-level definitions
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6