Issue 11365211: Revert the changes to co19; I didn't realize that I couldn't change these

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365211: Revert the changes to co19; I didn't realize that I couldn't change these (Closed)

Created:
8 years, 1 month ago by gram

Modified:
8 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert the changes to co19; I didn't realize that I couldn't change these tests. Committed: https://code.google.com/p/dart/source/detail?r=14824

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -3 lines)			Patch
	M	tests/co19/co19-compiler.status	View		1 chunk	+149 lines, -0 lines	0 comments	Download
	M	tests/co19/test_config.dart	View		1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 1 month ago (2012-11-13 00:30:55 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/11365211/diff/1/tests/co19/test_config...
File tests/co19/test_config.dart (right):

https://chromiumcodereview.appspot.com/11365211/diff/1/tests/co19/test_config...
tests/co19/test_config.dart:5: #library("co19_test_config");
this part of the fix you can keep, only revert the changes to the status file.

Expand Messages | Collapse Messages