Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 11365201: Remove TabContents from TabStripModelObserver::TabMoved. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove TabContents from TabStripModelObserver::TabMoved. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167358

Patch Set 1 #

Patch Set 2 : linux oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M chrome/browser/extensions/browser_event_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 1 month ago (2012-11-12 20:39:00 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-12 22:41:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11365201/1014
8 years, 1 month ago (2012-11-13 01:46:18 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-13 03:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11365201/1014
8 years, 1 month ago (2012-11-13 04:30:59 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 10:28:48 UTC) #6
Change committed as 167358

Powered by Google App Engine
This is Rietveld 408576698