Issue 11365157: Hard code order field for rietveld.py::get_pending_issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11365157: Hard code order field for rietveld.py::get_pending_issues (Closed)

Created:
8 years, 1 month ago by Isaac (away)

Modified:
8 years, 1 month ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Hard code order field for rietveld.py::get_pending_issues This is needed for https://codereview.appspot.com/6814091/ which changes the default ordering on codereview searches. R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166822

Patch Set 2 : Added TODO #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	rietveld.py	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm, I didn't recall it hadn't been updated. https://codereview.chromium.org/11365157/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/11365157/diff/1/rietveld.py#newcode75 rietveld.py:75: 'keys_only=True&limit=1000&order=__key__'))['results'] ...

8 years, 1 month ago (2012-11-08 21:04:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11365157/3

8 years, 1 month ago (2012-11-09 00:43:15 UTC) #3

Change committed as 166822

Expand Messages | Collapse Messages

Issue 11365157: Hard code order field for rietveld.py::get_pending_issues (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added TODO #

Messages