Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: rietveld.py

Issue 11365157: Hard code order field for rietveld.py::get_pending_issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Added TODO Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index a03fe77e3e8d216ca0e8590919d62d800ffa423a..d4ac39bab08060ea3c6414d3b9ad32b986d266f0 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -70,9 +70,10 @@ class Rietveld(object):
def get_pending_issues(self):
"""Returns an array of dict of all the pending issues on the server."""
- return json.loads(self.get(
- '/search?format=json&commit=2&closed=3&keys_only=True&limit=1000')
- )['results']
+ # TODO: Convert this to use Rietveld::search(), defined below.
+ return json.loads(
+ self.get('/search?format=json&commit=2&closed=3&'
+ 'keys_only=True&limit=1000&order=__key__'))['results']
def close_issue(self, issue):
"""Closes the Rietveld issue for this changelist."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698