Fix the issue of cursor being shown at startup.

Fix the issue of cursor being shown at startup.

Cursor was shown by MagnificationController when it's enabled in chrome::OpenAsh.
This CL makes MagnificationController not to show cursor if unnecessary.
Also makes cursor initially hidden when the host window is not using full screen
for testing ChromeOS build on desktop.

BUG=157918
TEST=Manually on device and desktop

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168830

[mazda, 2012-10-31 06:21:46]

Could you review this change?

derat: ash OWNER
yoshiki: MagnificationController

Thanks,

[Daniel Erat, 2012-10-31 13:18:53]

If aura::client::CursorClient keeps the shown/hidden state in a local variable,
would it be possible to add a test that checks that we start in the correct
state?

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init.cc
File chrome/browser/ui/ash/ash_init.cc (right):

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init...
chrome/browser/ui/ash/ash_init.cc:61:
ash::Shell::set_initially_hide_cursor(true);
Just to double-check, is it still shown as soon as the user moves the mouse?

I'm not sure that this is the right behavior.  I think that most developers run
local builds in non-logged-in mode; it might be strange if the cursor is always
hidden when they do that.  I think we really only want to hide it when we're
displaying the login screen or OOBE.

[yoshiki, 2012-11-09 05:46:40]

MagnificationController lgtm.

[mazda, 2012-11-20 03:30:20]

Sorry for this late reply.

I added tests and modified OpenAsh.
I noticed that cursor appeared to be hidden at startup without this CL after
http://src.chromium.org/viewvc/chrome?view=rev&revision=164452.
But ShowCursor(true) is still called in
MagnificationControllerImpl::OnImplicitAnimationsCompleted.
The reason why the cursor appeared to be hidden is that the cursor type is set
to kCursorNone at that time.
In order to avoid this confusing behavior, I added code to initialize cursor
type to Shell::Init.

Please take another look.

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init.cc
File chrome/browser/ui/ash/ash_init.cc (right):

http://codereview.chromium.org/11364003/diff/1/chrome/browser/ui/ash/ash_init...
chrome/browser/ui/ash/ash_init.cc:61:
ash::Shell::set_initially_hide_cursor(true);
On 2012/10/31 13:18:53, Daniel Erat wrote:
> Just to double-check, is it still shown as soon as the user moves the mouse?
Yes, CompoundEventFilter::SetCursorVisibilityOnEvent will show the cursor as
soon as the user moves the mouse.

> I'm not sure that this is the right behavior.  I think that most developers
run
> local builds in non-logged-in mode; it might be strange if the cursor is
always
> hidden when they do that.  I think we really only want to hide it when we're
> displaying the login screen or OOBE.
That's a good point. I changed the code to hide cursor only when displaying the
login screen if developer runs local builds on desktop.

[Daniel Erat, 2012-11-20 14:19:38]

lgtm

[commit-bot: I haz the power, 2012-11-20 15:43:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/11364003/11001

[commit-bot: I haz the power, 2012-11-20 17:53:27]

Change committed as 168830