Issue 11363203: Get rid of use of CreateStringValue in chromeos/ directory.

Issue 11363203: Get rid of use of CreateStringValue in chromeos/ directory. (Closed)

Created:
8 years, 1 month ago by Evan Stade

Modified:
8 years, 1 month ago

Reviewers:
stevenjb, brettw, DaveMoore

CC:
chromium-reviews, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of use of CreateStringValue in chromeos/ directory. BUG=160586 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167808

Patch Set 1 #

Total comments: 2

Patch Set 2 : +D #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -121 lines)			Patch
M	base/values.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cros_network_functions.cc	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cros_network_functions_unittest.cc	View	1	15 chunks	+45 lines, -45 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1	4 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_ui_data_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/echo_private_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_handler_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/info_private_api.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/info_private_api.cc	View	1	2 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_manager_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/media/media_player_extension_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/proxy_cros_settings_parser.cc	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/settings/cros_settings_unittest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/settings/system_settings_provider.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/settings/system_settings_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm http://codereview.chromium.org/11363203/diff/1/chrome/browser/chromeos/extensions/info_private_api.cc File chrome/browser/chromeos/extensions/info_private_api.cc (right): http://codereview.chromium.org/11363203/diff/1/chrome/browser/chromeos/extensions/info_private_api.cc#newcode91 chrome/browser/chromeos/extensions/info_private_api.cc:91: LOG(ERROR) << "Unknown property request: " << property_name; ...

8 years, 1 month ago (2012-11-13 22:43:42 UTC) #5

Evan Stade

http://codereview.chromium.org/11363203/diff/1/chrome/browser/chromeos/extensions/info_private_api.cc File chrome/browser/chromeos/extensions/info_private_api.cc (right): http://codereview.chromium.org/11363203/diff/1/chrome/browser/chromeos/extensions/info_private_api.cc#newcode91 chrome/browser/chromeos/extensions/info_private_api.cc:91: LOG(ERROR) << "Unknown property request: " << property_name; On ...

8 years, 1 month ago (2012-11-14 22:33:27 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11363203/5001

8 years, 1 month ago (2012-11-14 22:33:50 UTC) #7

Change committed as 167808

Expand Messages | Collapse Messages