Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: base/values.h

Issue 11363203: Get rid of use of CreateStringValue in chromeos/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: +D Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/cros_network_functions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index d7263dfbc731fa8998af0de79f64936399cca4d8..6b650052accf75d2e777e60e988526fbb609e078 100644
--- a/base/values.h
+++ b/base/values.h
@@ -66,10 +66,9 @@ class BASE_EXPORT Value {
virtual ~Value();
- // Convenience methods for creating Value objects for various
- // kinds of values without thinking about which class implements them.
- // These can always be expected to return a valid Value*.
static Value* CreateNullValue();
+ // DEPRECATED: Do not use the following 5 functions. Instead, use
+ // new FundamentalValue or new StringValue.
static FundamentalValue* CreateBooleanValue(bool in_value);
static FundamentalValue* CreateIntegerValue(int in_value);
static FundamentalValue* CreateDoubleValue(double in_value);
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/cros_network_functions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698