Don't use drag to corner resizing for unresizable windows

Don't use drag to corner resizing for unresizable windows


BUG=157963
TEST=visual & unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167554

[Mr4D (OOO till 08-26), 2012-11-10 00:54:55]

I found a way without adding another function - but please let me know if you
think we should add one!

[sky, 2012-11-12 03:56:08]

https://codereview.chromium.org/11363177/diff/1/ash/wm/workspace/workspace_wi...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/1/ash/wm/workspace/workspace_wi...
ash/wm/workspace/workspace_window_resizer.cc:293: views::Widget* widget =
views::Widget::GetWidgetForNativeWindow(window());
If all windows were created by widgets, this change would be reasonable. But
that need not be the case. The property approach is better since it can work
with a window created in any way.

[Mr4D (OOO till 08-26), 2012-11-12 18:25:01]

Done. Please have another look!

https://codereview.chromium.org/11363177/diff/1/ash/wm/workspace/workspace_wi...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/1/ash/wm/workspace/workspace_wi...
ash/wm/workspace/workspace_window_resizer.cc:293: views::Widget* widget =
views::Widget::GetWidgetForNativeWindow(window());
On 2012/11/12 03:56:08, sky wrote:
> If all windows were created by widgets, this change would be reasonable. But
> that need not be the case. The property approach is better since it can work
> with a window created in any way.

Done.

[sky, 2012-11-12 22:09:08]

https://codereview.chromium.org/11363177/diff/3008/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/3008/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:291: if (in_original_root &&
wm::CanResizeWindow(window())) {
What is preventing the window from being resized by a corner now? By that I mean
presumably right now you can't grab a corner of the calculate and resize it.
What stops that?

Also, what about LayoutAttachedWindows? Don't you need to update that too?

[Mr4D (OOO till 08-26), 2012-11-13 01:39:53]

Addressed, added both cases and a unit test.

https://codereview.chromium.org/11363177/diff/3008/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/3008/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:291: if (in_original_root &&
wm::CanResizeWindow(window())) {
Corner resizing:
the FramePainter::NonClientHitTest checks already the widget directly for
resizability. But as discussed moved the test into CreateWindowResizer.

Added a MultiWindowResize check (and unit test) as well.

[sky, 2012-11-13 17:01:54]

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/multi_win...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/multi_win...
ash/wm/workspace/multi_window_resize_controller.cc:291:
!wm::CanResizeWindow(window))
The multi-window resizer may just move the other window, which is fine. It's the
resizing we need to disallow. You'll need to change WorkspaceWindowResizer where
it calculates how and what to resize.

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:40: if
(!wm::CanResizeWindow(window))
Doesn't returning null here mean you can't drag from the caption at all? A
better place for this is in Details constructor. I believe if you set
is_resizable to false there when the window isn't resizable and the component
isn't the caption it'll take care of it.

[Mr4D (OOO till 08-26), 2012-11-13 21:27:22]

Addressed. Please have another look!

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/multi_win...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/multi_win...
ash/wm/workspace/multi_window_resize_controller.cc:291:
!wm::CanResizeWindow(window))
After investigating I have figured out that the frame_painter.cc's
NonClientHitTest function is not allowing the window to get resized by not
generating the resize handle codes. As a result of that the
multi_window_resize_controller does not include such windows into a sizing
operation. As such I was removing these two test conditions (since they will
never get called) and the unit test for this condition (which will never happen
at this level).

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/11363177/diff/1005/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_window_resizer.cc:40: if
(!wm::CanResizeWindow(window))
The suggestion to do this came from you ( :) ) - but - this is the way to go
since the is_resizable variable from details seems to be used to block
everything (bad naming? - see window_resizer.cc, line 174). To address your
concern I added another check for the hit test which seems to be the right thing
to do. Addressed.

[sky, 2012-11-13 22:18:11]

LGTM

[commit-bot: I haz the power, 2012-11-13 22:47:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/11363177/5008

[commit-bot: I haz the power, 2012-11-14 01:16:10]

Change committed as 167554