Issue 11363033: Extends IBusText to handle mozc's extended field.

Issue 11363033: Extends IBusText to handle mozc's extended field. (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka

Modified:
8 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hsumita

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extends IBusText to handle mozc's extended field. This is part of mozc dependency removal and libibus removal. BUG=129403 TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166175

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -37 lines)			Patch
M	chromeos/dbus/ibus/ibus_text.h	View	1	3 chunks	+31 lines, -8 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_text.cc	View		3 chunks	+45 lines, -29 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_text_unittest.cc	View		1 chunk	+108 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

satorux1

http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h File chromeos/dbus/ibus/ibus_text.h (right): http://codereview.chromium.org/11363033/diff/1/chromeos/dbus/ibus/ibus_text.h#newcode144 chromeos/dbus/ibus/ibus_text.h:144: std::string text() const { return text_; } const std::string& ...

8 years, 1 month ago (2012-11-05 04:29:16 UTC) #2

Seigo Nonaka

8 years, 1 month ago (2012-11-05 05:27:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11363033/5001

8 years, 1 month ago (2012-11-06 06:32:07 UTC) #5

Change committed as 166175

Expand Messages | Collapse Messages