build/landmines.py - Issue 11362244: Fix NotImplementedError for vs and ib build-tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 11362244: Fix NotImplementedError for vs and ib build-tools (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index 36253e9badd5bcdc9d752f1e194eef3f53bc0ec5..321c5963a5a7f9e3254943d0b6b9bf5733f3f417 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -158,7 +158,7 @@ def get_target_build_dir(build_tool, target, is_iphone=False):

ret = os.path.join(SRC_DIR, 'out', target)

elif build_tool == 'ninja':

ret = os.path.join(SRC_DIR, 'out', target)

- elif build_tool == 'msvs':

+ elif build_tool in ['msvs', 'vs', 'ib']:

ret = os.path.join(SRC_DIR, 'build', target)

elif build_tool == 'scons':

ret = os.path.join(SRC_DIR, 'sconsbuild', target)

« no previous file with comments | « no previous file | no next file » | no next file with comments »