Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: build/landmines.py

Issue 11362244: Fix NotImplementedError for vs and ib build-tools (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file holds a list of reasons why a particular build needs to be clobbered 7 This file holds a list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 9
10 This script runs every build as a hook. If it detects that the build should 10 This script runs every build as a hook. If it detects that the build should
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 Keep this function in sync with tools/build/scripts/slave/compile.py 151 Keep this function in sync with tools/build/scripts/slave/compile.py
152 """ 152 """
153 ret = None 153 ret = None
154 if build_tool == 'xcode': 154 if build_tool == 'xcode':
155 ret = os.path.join(SRC_DIR, 'xcodebuild', 155 ret = os.path.join(SRC_DIR, 'xcodebuild',
156 target + ('-iphoneos' if is_iphone else '')) 156 target + ('-iphoneos' if is_iphone else ''))
157 elif build_tool == 'make': 157 elif build_tool == 'make':
158 ret = os.path.join(SRC_DIR, 'out', target) 158 ret = os.path.join(SRC_DIR, 'out', target)
159 elif build_tool == 'ninja': 159 elif build_tool == 'ninja':
160 ret = os.path.join(SRC_DIR, 'out', target) 160 ret = os.path.join(SRC_DIR, 'out', target)
161 elif build_tool == 'msvs': 161 elif build_tool in ['msvs', 'vs', 'ib']:
162 ret = os.path.join(SRC_DIR, 'build', target) 162 ret = os.path.join(SRC_DIR, 'build', target)
163 elif build_tool == 'scons': 163 elif build_tool == 'scons':
164 ret = os.path.join(SRC_DIR, 'sconsbuild', target) 164 ret = os.path.join(SRC_DIR, 'sconsbuild', target)
165 else: 165 else:
166 raise NotImplementedError() 166 raise NotImplementedError()
167 return os.path.abspath(ret) 167 return os.path.abspath(ret)
168 168
169 169
170 def main(argv): 170 def main(argv):
171 if len(argv) > 1: 171 if len(argv) > 1:
(...skipping 29 matching lines...) Expand all
201 f.writelines(diff) 201 f.writelines(diff)
202 elif os.path.exists(triggered): 202 elif os.path.exists(triggered):
203 # Remove false triggered landmines. 203 # Remove false triggered landmines.
204 os.remove(triggered) 204 os.remove(triggered)
205 205
206 return 0 206 return 0
207 207
208 208
209 if __name__ == '__main__': 209 if __name__ == '__main__':
210 sys.exit(main(sys.argv)) 210 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698