Added support for CSS filters to the software compositor.

Added support for CSS filters to the software compositor.


BUG=160302
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167747

[Stephen White, 2012-11-14 01:07:16]

This LGTM from a filters point of view, although I know nothing about the
software compositor.

https://codereview.chromium.org/11362235/diff/1/cc/software_renderer.cc
File cc/software_renderer.cc (right):

https://codereview.chromium.org/11362235/diff/1/cc/software_renderer.cc#newco...
cc/software_renderer.cc:307: m_skCurrentPaint.setImageFilter(filter);
You'll only get non-NULL SkImageFIlters here when the new path is forced on in
GraphicsLayerChromium over in WebKit-land (but you knew that).

[slavi, 2012-11-14 01:17:43]

https://codereview.chromium.org/11362235/diff/1/cc/software_renderer.cc
File cc/software_renderer.cc (right):

https://codereview.chromium.org/11362235/diff/1/cc/software_renderer.cc#newco...
cc/software_renderer.cc:307: m_skCurrentPaint.setImageFilter(filter);
I know. And the plan is to always get a non-NULL SkImageFilters if there is a
filter on the layer in the future. Keep me posted when that happens.

[slavi, 2012-11-14 19:14:55]

@enne @jamesr

Ping. 

That should be trivial to review.

[enne (OOO), 2012-11-14 19:18:53]

lgtm

Sorry, for some reason I thought we had put senorblanco down in cc OWNERS for
filter-related code.

[commit-bot: I haz the power, 2012-11-14 19:32:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/11362235/12001

[commit-bot: I haz the power, 2012-11-14 21:21:57]

Change committed as 167747