Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11362171: GPUChannel pools mailbox names. (Closed)

Created:
8 years, 1 month ago by apatrick_chromium
Modified:
8 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

GPUChannel pools mailbox names. It asynchronously refills the pool to a target size when it falls below half that size. GenerateMailboxNames is only synchronous if the pool is depleted. Common case is a few microseconds per name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166962

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -3 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 3 chunks +7 lines, -0 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 3 chunks +50 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
apatrick_chromium
8 years, 1 month ago (2012-11-08 23:36:27 UTC) #1
apatrick_chromium
https://codereview.chromium.org/11362171/diff/7002/content/common/gpu/client/gpu_channel_host.cc File content/common/gpu/client/gpu_channel_host.cc (right): https://codereview.chromium.org/11362171/diff/7002/content/common/gpu/client/gpu_channel_host.cc#newcode325 content/common/gpu/client/gpu_channel_host.cc:325: if (message.is_sync()) This should be is_reply. Don't know why ...
8 years, 1 month ago (2012-11-08 23:57:29 UTC) #2
piman
LGTM with the typo fixed.
8 years, 1 month ago (2012-11-09 00:05:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/11362171/12006
8 years, 1 month ago (2012-11-09 00:07:18 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) nacl_integration
8 years, 1 month ago (2012-11-09 03:54:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/11362171/12006
8 years, 1 month ago (2012-11-09 19:09:08 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 19:50:38 UTC) #7
Change committed as 166962

Powered by Google App Engine
This is Rietveld 408576698