Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 11362111: Fix: infolist requries description title. (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka
Modified:
8 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix: infolist requries description title. Sorry I misunderstand the infolist spec, infolist requires title field. I split description field into description_title and description_body. BUG=129403 TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168544

Patch Set 1 #

Patch Set 2 : reupload #

Total comments: 4

Patch Set 3 : Rebase on http://codereview.chromium.org/11361210/ #

Patch Set 4 : Address comments on 11361210 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -21 lines) Patch
M chromeos/dbus/ibus/ibus_lookup_table.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_text.h View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_text.cc View 1 2 3 3 chunks +27 lines, -12 lines 0 comments Download
M chromeos/dbus/ibus/ibus_text_unittest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Seigo Nonaka
8 years, 1 month ago (2012-11-08 07:13:55 UTC) #1
satorux1
side-by-side diffs don't work for some reason. Could you upload again?
8 years, 1 month ago (2012-11-08 08:24:16 UTC) #2
Seigo Nonaka
Opps, sorry uploaded.
8 years, 1 month ago (2012-11-08 08:28:29 UTC) #3
satorux1
http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_text_unittest.cc File chromeos/dbus/ibus/ibus_text_unittest.cc (right): http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_text_unittest.cc#newcode161 chromeos/dbus/ibus/ibus_text_unittest.cc:161: // Write attachment field. Maybe // Write attachment fields. ...
8 years, 1 month ago (2012-11-08 08:39:30 UTC) #4
Seigo Nonaka
http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_text_unittest.cc File chromeos/dbus/ibus/ibus_text_unittest.cc (right): http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_text_unittest.cc#newcode161 chromeos/dbus/ibus/ibus_text_unittest.cc:161: // Write attachment field. Sure will do. On 2012/11/08 ...
8 years, 1 month ago (2012-11-12 06:13:11 UTC) #5
Seigo Nonaka
ping? just in case
8 years, 1 month ago (2012-11-19 07:42:40 UTC) #6
satorux1
LGTM
8 years, 1 month ago (2012-11-19 08:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11362111/11006
8 years, 1 month ago (2012-11-19 15:20:24 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-19 17:16:46 UTC) #9
Change committed as 168544

Powered by Google App Engine
This is Rietveld 408576698