Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: chromeos/dbus/ibus/ibus_text_unittest.cc

Issue 11362111: Fix: infolist requries description title. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments on 11361210 Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/ibus/ibus_text.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_text_unittest.cc
diff --git a/chromeos/dbus/ibus/ibus_text_unittest.cc b/chromeos/dbus/ibus/ibus_text_unittest.cc
index d87bf39b1c0f2462a1e2bf4bf79603a0bc410648..b829123d6093af76462071631e88e8dda405ce65 100644
--- a/chromeos/dbus/ibus/ibus_text_unittest.cc
+++ b/chromeos/dbus/ibus/ibus_text_unittest.cc
@@ -22,7 +22,8 @@ namespace ibus {
TEST(IBusTextTest, WriteReadTest) {
const char kSampleText[] = "Sample Text";
const char kAnnotation[] = "Annotation";
- const char kDescription[] = "Description";
+ const char kDescriptionTitle[] = "Description Title";
+ const char kDescriptionBody[] = "Description Body";
const IBusText::UnderlineAttribute kSampleUnderlineAttribute1 = {
IBusText::IBUS_TEXT_UNDERLINE_SINGLE, 10, 20};
@@ -38,7 +39,8 @@ TEST(IBusTextTest, WriteReadTest) {
IBusText text;
text.set_text(kSampleText);
text.set_annotation(kAnnotation);
- text.set_description(kDescription);
+ text.set_description_title(kDescriptionTitle);
+ text.set_description_body(kDescriptionBody);
std::vector<IBusText::UnderlineAttribute>* underline_attributes =
text.mutable_underline_attributes();
underline_attributes->push_back(kSampleUnderlineAttribute1);
@@ -59,7 +61,8 @@ TEST(IBusTextTest, WriteReadTest) {
ASSERT_TRUE(PopIBusText(&reader, &expected_text));
EXPECT_EQ(kSampleText, expected_text.text());
EXPECT_EQ(kAnnotation, expected_text.annotation());
- EXPECT_EQ(kDescription, expected_text.description());
+ EXPECT_EQ(kDescriptionTitle, expected_text.description_title());
+ EXPECT_EQ(kDescriptionBody, expected_text.description_body());
EXPECT_EQ(3U, expected_text.underline_attributes().size());
EXPECT_EQ(1U, expected_text.selection_attributes().size());
}
« no previous file with comments | « chromeos/dbus/ibus/ibus_text.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698