check the permission for wake lock before calling setWakeMode

check the permission for wake lock before calling setWakeMode


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165311

[qinmin, 2012-10-31 18:42:50]

PTAL

[Yaron, 2012-10-31 19:26:39]

https://codereview.chromium.org/11362018/diff/1/media/base/android/java/src/o...
File media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
(right):

https://codereview.chromium.org/11362018/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/MediaPlayerListener.java:98: if
(PackageManager.PERMISSION_GRANTED ==
Shouldn't we just add the WAKE_LOCK permission? Is there a way that the
permission can be rejected? Is there a specific bug associated with this?

[qinmin, 2012-10-31 20:12:11]

This is for the webview, which does not have permissions.

On 2012/10/31 19:26:39, Yaron wrote:
>
https://codereview.chromium.org/11362018/diff/1/media/base/android/java/src/o...
> File media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
> (right):
> 
>
https://codereview.chromium.org/11362018/diff/1/media/base/android/java/src/o...
> media/base/android/java/src/org/chromium/media/MediaPlayerListener.java:98: if
> (PackageManager.PERMISSION_GRANTED ==
> Shouldn't we just add the WAKE_LOCK permission? Is there a way that the
> permission can be rejected? Is there a specific bug associated with this?

[Yaron, 2012-10-31 20:18:52]

lgtm

[commit-bot: I haz the power, 2012-10-31 21:39:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/11362018/1

[commit-bot: I haz the power, 2012-10-31 21:52:47]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-01 00:15:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/11362018/1

[commit-bot: I haz the power, 2012-11-01 08:16:33]

Change committed as 165311

[joth, 2012-11-01 10:26:22]

Thanks qinmin!
Did you have any thoughts on using LayoutParams FLAG_KEEP_SCREEN_ON for
apps without the permission, or for all cases? (I could raise a lower prior
crbug for to look into that if needed)





On 1 November 2012 08:16, <commit-bot@chromium.org> wrote:

> Change committed as 165311
>
>
https://chromiumcodereview.**appspot.com/11362018/<https://chromiumcodereview...
>

[qinmin, 2012-11-01 13:16:48]

For MediaPlayer, i think we have to use PowerManager constants as the API
does not create a new wakelock directly. But I think we can use that
constant else if we are creating a wake lock

Min

On Thu, Nov 1, 2012 at 3:26 AM, Jonathan Dixon <joth@chromium.org> wrote:

> Thanks qinmin!
> Did you have any thoughts on using LayoutParams FLAG_KEEP_SCREEN_ON for
> apps without the permission, or for all cases? (I could raise a lower prior
> crbug for to look into that if needed)
>
>
>
>
>
> On 1 November 2012 08:16, <commit-bot@chromium.org> wrote:
>
>> Change committed as 165311
>>
>>
https://chromiumcodereview.**appspot.com/11362018/<https://chromiumcodereview...
>>
>
>