Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3350)

Unified Diff: build/common.gypi

Issue 11361240: Add the -Wobjc-missing-property-synthesis flag. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add to ios block Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 96e2fb79a55a8ab76b508638e2dccd4228544c8e..9f118c57933c2c8256acef89b9e183883ad6de2b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2553,7 +2553,7 @@
# removed when we change to that. (This is also why we don't
# bother fixing all these cases today.)
'-Wno-unnamed-type-template-args',
- # This (rightyfully) complains about 'override', which we use
+ # This (rightfully) complains about 'override', which we use
# heavily.
'-Wno-c++11-extensions',
@@ -3086,11 +3086,12 @@
'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++',
# Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when buliding with clang. This warning is triggered when the
+ # when building with clang. This warning is triggered when the
# override keyword is used via the OVERRIDE macro from
# base/compiler_specific.h.
'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
-
+ # Warn if automatic synthesis is triggered.
+ 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
Mark Mentovai 2012/11/15 00:07:51 One nit: we almost always put the -W name in a com
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
'WARNING_CFLAGS': [
'-Wheader-hygiene',
@@ -3101,7 +3102,7 @@
'-Wno-unused-function',
# See comments on this flag higher up in this file.
'-Wno-unnamed-type-template-args',
- # This (rightyfully) complains about 'override', which we use
+ # This (rightfully) complains about 'override', which we use
# heavily.
'-Wno-c++11-extensions',
@@ -3315,10 +3316,12 @@
# also seems to mean using the custom build of clang.
# Don't use -Wc++0x-extensions, which Xcode 4 enables by default
- # when buliding with clang. This warning is triggered when the
+ # when building with clang. This warning is triggered when the
# override keyword is used via the OVERRIDE macro from
# base/compiler_specific.h.
'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
+ # Warn if automatic synthesis is triggered.
+ 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
'WARNING_CFLAGS': [
'-Wheader-hygiene',
# Don't die on dtoa code that uses a char as an array index.
@@ -3328,7 +3331,7 @@
'-Wno-unused-function',
# See comments on this flag higher up in this file.
'-Wno-unnamed-type-template-args',
- # This (rightyfully) complains about 'override', which we use
+ # This (rightfully) complains about 'override', which we use
# heavily.
'-Wno-c++11-extensions',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698