 Chromium Code Reviews
 Chromium Code Reviews Issue 11361240:
  Add the -Wobjc-missing-property-synthesis flag.  (Closed) 
  Base URL: http://git.chromium.org/chromium/src.git@master
    
  
    Issue 11361240:
  Add the -Wobjc-missing-property-synthesis flag.  (Closed) 
  Base URL: http://git.chromium.org/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 # IMPORTANT: | 5 # IMPORTANT: | 
| 6 # Please don't directly include this file if you are building via gyp_chromium, | 6 # Please don't directly include this file if you are building via gyp_chromium, | 
| 7 # since gyp_chromium is automatically forcing its inclusion. | 7 # since gyp_chromium is automatically forcing its inclusion. | 
| 8 { | 8 { | 
| 9 # Variables expected to be overriden on the GYP command line (-D) or by | 9 # Variables expected to be overriden on the GYP command line (-D) or by | 
| 10 # ~/.gyp/include.gypi. | 10 # ~/.gyp/include.gypi. | 
| (...skipping 2535 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2546 # Clang spots more unused functions. | 2546 # Clang spots more unused functions. | 
| 2547 '-Wno-unused-function', | 2547 '-Wno-unused-function', | 
| 2548 # Don't die on dtoa code that uses a char as an array index. | 2548 # Don't die on dtoa code that uses a char as an array index. | 
| 2549 '-Wno-char-subscripts', | 2549 '-Wno-char-subscripts', | 
| 2550 # Especially needed for gtest macros using enum values from Mac | 2550 # Especially needed for gtest macros using enum values from Mac | 
| 2551 # system headers. | 2551 # system headers. | 
| 2552 # TODO(pkasting): In C++11 this is legal, so this should be | 2552 # TODO(pkasting): In C++11 this is legal, so this should be | 
| 2553 # removed when we change to that. (This is also why we don't | 2553 # removed when we change to that. (This is also why we don't | 
| 2554 # bother fixing all these cases today.) | 2554 # bother fixing all these cases today.) | 
| 2555 '-Wno-unnamed-type-template-args', | 2555 '-Wno-unnamed-type-template-args', | 
| 2556 # This (rightyfully) complains about 'override', which we use | 2556 # This (rightfully) complains about 'override', which we use | 
| 2557 # heavily. | 2557 # heavily. | 
| 2558 '-Wno-c++11-extensions', | 2558 '-Wno-c++11-extensions', | 
| 2559 | 2559 | 
| 2560 # Warns on switches on enums that cover all enum values but | 2560 # Warns on switches on enums that cover all enum values but | 
| 2561 # also contain a default: branch. Chrome is full of that. | 2561 # also contain a default: branch. Chrome is full of that. | 
| 2562 '-Wno-covered-switch-default', | 2562 '-Wno-covered-switch-default', | 
| 2563 ], | 2563 ], | 
| 2564 'cflags!': [ | 2564 'cflags!': [ | 
| 2565 # Clang doesn't seem to know know this flag. | 2565 # Clang doesn't seem to know know this flag. | 
| 2566 '-mfpmath=sse', | 2566 '-mfpmath=sse', | 
| (...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3079 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, | 3079 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, | 
| 3080 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} | 3080 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} | 
| 3081 ], | 3081 ], | 
| 3082 # Note that the prebuilt Clang binaries should not be used for iOS | 3082 # Note that the prebuilt Clang binaries should not be used for iOS | 
| 3083 # development except for ASan builds. | 3083 # development except for ASan builds. | 
| 3084 ['clang==1', { | 3084 ['clang==1', { | 
| 3085 'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang', | 3085 'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang', | 
| 3086 'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++', | 3086 'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++', | 
| 3087 | 3087 | 
| 3088 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default | 3088 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default | 
| 3089 # when buliding with clang. This warning is triggered when the | 3089 # when building with clang. This warning is triggered when the | 
| 3090 # override keyword is used via the OVERRIDE macro from | 3090 # override keyword is used via the OVERRIDE macro from | 
| 3091 # base/compiler_specific.h. | 3091 # base/compiler_specific.h. | 
| 3092 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO', | 3092 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO', | 
| 3093 | 3093 # Warn if automatic synthesis is triggered. | 
| 3094 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES', | |
| 
Mark Mentovai
2012/11/15 00:07:51
One nit: we almost always put the -W name in a com
 | |
| 3094 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', | 3095 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', | 
| 3095 'WARNING_CFLAGS': [ | 3096 'WARNING_CFLAGS': [ | 
| 3096 '-Wheader-hygiene', | 3097 '-Wheader-hygiene', | 
| 3097 # Don't die on dtoa code that uses a char as an array index. | 3098 # Don't die on dtoa code that uses a char as an array index. | 
| 3098 # This is required solely for base/third_party/dmg_fp/dtoa.cc. | 3099 # This is required solely for base/third_party/dmg_fp/dtoa.cc. | 
| 3099 '-Wno-char-subscripts', | 3100 '-Wno-char-subscripts', | 
| 3100 # Clang spots more unused functions. | 3101 # Clang spots more unused functions. | 
| 3101 '-Wno-unused-function', | 3102 '-Wno-unused-function', | 
| 3102 # See comments on this flag higher up in this file. | 3103 # See comments on this flag higher up in this file. | 
| 3103 '-Wno-unnamed-type-template-args', | 3104 '-Wno-unnamed-type-template-args', | 
| 3104 # This (rightyfully) complains about 'override', which we use | 3105 # This (rightfully) complains about 'override', which we use | 
| 3105 # heavily. | 3106 # heavily. | 
| 3106 '-Wno-c++11-extensions', | 3107 '-Wno-c++11-extensions', | 
| 3107 | 3108 | 
| 3108 # Warns on switches on enums that cover all enum values but | 3109 # Warns on switches on enums that cover all enum values but | 
| 3109 # also contain a default: branch. Chrome is full of that. | 3110 # also contain a default: branch. Chrome is full of that. | 
| 3110 '-Wno-covered-switch-default', | 3111 '-Wno-covered-switch-default', | 
| 3111 ], | 3112 ], | 
| 3112 }], | 3113 }], | 
| 3113 ['clang==1 and clang_use_chrome_plugins==1', { | 3114 ['clang==1 and clang_use_chrome_plugins==1', { | 
| 3114 'OTHER_CFLAGS': [ | 3115 'OTHER_CFLAGS': [ | 
| (...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3308 ['OS=="ios"', { | 3309 ['OS=="ios"', { | 
| 3309 'target_defaults': { | 3310 'target_defaults': { | 
| 3310 'xcode_settings' : { | 3311 'xcode_settings' : { | 
| 3311 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', | 3312 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', | 
| 3312 | 3313 | 
| 3313 # This next block is mostly common with the 'mac' section above, | 3314 # This next block is mostly common with the 'mac' section above, | 
| 3314 # but keying off (or setting) 'clang' isn't valid for iOS as it | 3315 # but keying off (or setting) 'clang' isn't valid for iOS as it | 
| 3315 # also seems to mean using the custom build of clang. | 3316 # also seems to mean using the custom build of clang. | 
| 3316 | 3317 | 
| 3317 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default | 3318 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default | 
| 3318 # when buliding with clang. This warning is triggered when the | 3319 # when building with clang. This warning is triggered when the | 
| 3319 # override keyword is used via the OVERRIDE macro from | 3320 # override keyword is used via the OVERRIDE macro from | 
| 3320 # base/compiler_specific.h. | 3321 # base/compiler_specific.h. | 
| 3321 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO', | 3322 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO', | 
| 3323 # Warn if automatic synthesis is triggered. | |
| 3324 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES', | |
| 3322 'WARNING_CFLAGS': [ | 3325 'WARNING_CFLAGS': [ | 
| 3323 '-Wheader-hygiene', | 3326 '-Wheader-hygiene', | 
| 3324 # Don't die on dtoa code that uses a char as an array index. | 3327 # Don't die on dtoa code that uses a char as an array index. | 
| 3325 # This is required solely for base/third_party/dmg_fp/dtoa.cc. | 3328 # This is required solely for base/third_party/dmg_fp/dtoa.cc. | 
| 3326 '-Wno-char-subscripts', | 3329 '-Wno-char-subscripts', | 
| 3327 # Clang spots more unused functions. | 3330 # Clang spots more unused functions. | 
| 3328 '-Wno-unused-function', | 3331 '-Wno-unused-function', | 
| 3329 # See comments on this flag higher up in this file. | 3332 # See comments on this flag higher up in this file. | 
| 3330 '-Wno-unnamed-type-template-args', | 3333 '-Wno-unnamed-type-template-args', | 
| 3331 # This (rightyfully) complains about 'override', which we use | 3334 # This (rightfully) complains about 'override', which we use | 
| 3332 # heavily. | 3335 # heavily. | 
| 3333 '-Wno-c++11-extensions', | 3336 '-Wno-c++11-extensions', | 
| 3334 ], | 3337 ], | 
| 3335 }, | 3338 }, | 
| 3336 'target_conditions': [ | 3339 'target_conditions': [ | 
| 3337 ['_type=="executable"', { | 3340 ['_type=="executable"', { | 
| 3338 'configurations': { | 3341 'configurations': { | 
| 3339 'Release_Base': { | 3342 'Release_Base': { | 
| 3340 'xcode_settings': { | 3343 'xcode_settings': { | 
| 3341 'DEPLOYMENT_POSTPROCESSING': 'YES', | 3344 'DEPLOYMENT_POSTPROCESSING': 'YES', | 
| (...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3733 # settings in target dicts. SYMROOT is a special case, because many other | 3736 # settings in target dicts. SYMROOT is a special case, because many other | 
| 3734 # Xcode variables depend on it, including variables such as | 3737 # Xcode variables depend on it, including variables such as | 
| 3735 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something | 3738 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something | 
| 3736 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the | 3739 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the | 
| 3737 # files to appear (when present) in the UI as actual files and not red | 3740 # files to appear (when present) in the UI as actual files and not red | 
| 3738 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, | 3741 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, | 
| 3739 # and therefore SYMROOT, needs to be set at the project level. | 3742 # and therefore SYMROOT, needs to be set at the project level. | 
| 3740 'SYMROOT': '<(DEPTH)/xcodebuild', | 3743 'SYMROOT': '<(DEPTH)/xcodebuild', | 
| 3741 }, | 3744 }, | 
| 3742 } | 3745 } | 
| OLD | NEW |