Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 11361211: chromeos: Remove unused CrosAddIPConfig/CrosRemoveIPConfig functions (Closed)

Created:
8 years, 1 month ago by hashimoto
Modified:
8 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove unused CrosAddIPConfig/CrosRemoveIPConfig functions BUG=126964 TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -161 lines) Patch
M chrome/browser/chromeos/cros/cros_network_functions.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chromeos/dbus/shill_client_helper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_client_helper.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chromeos/dbus/shill_device_client.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_device_client.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
8 years, 1 month ago (2012-11-12 07:00:22 UTC) #1
stevenjb
+gspencer who did the async work. Hopefully we will be removing all of cros_network_functions in ...
8 years, 1 month ago (2012-11-12 17:35:24 UTC) #2
Greg Spencer (Chromium)
LGTM Thanks for removing these.
8 years, 1 month ago (2012-11-12 20:04:05 UTC) #3
hashimoto
On 2012/11/12 17:35:24, stevenjb (chromium) wrote: > +gspencer who did the async work. > > ...
8 years, 1 month ago (2012-11-13 02:04:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11361211/1
8 years, 1 month ago (2012-11-13 02:15:14 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-13 08:50:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11361211/1
8 years, 1 month ago (2012-11-13 10:11:49 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 10:12:33 UTC) #8
Change committed as 167354

Powered by Google App Engine
This is Rietveld 408576698